client_secret and clientSecret about bell

[qualquervalor]

I think it might have been a typo
#101

[jeffwhelpley]

Yeah, I figured as much. Thanks @qualquervalor for submitting a PR!

[ldesplat]

Sorry about that. I had tested the code with my own provider but I was using Authorization header which used the right variable :(

[jeffwhelpley]

@ldesplat no worries. One thing. Unless I am mistaken it looks like the PR from @qualquervalor was merged, but the version number hasn't been incremented and published to npm.

[xrysanthos]

Hi guys! Are you planning a release with this fix soon? I've just discovered the issue and couldn't login with most of the networks due to this error.

[Icehunter]

@hueniverse I was wondering if the NPM/package version can be incremented from the change here: https://github.com/hapijs/bell/blob/master/lib/oauth.js#L199 ?

4.0.0 does not have that line and is currently breaking on facebook and other providers.

Thanks for all the work! :)

[hueniverse]

@geek Care to publish a new version with the fix?

[ericeslinger]

Yep, I'd sure love to see a new version, I independently found this bug and was in the midst of forking to submit a PR when I found it had already been fixed in master. I rolled back to 3.0.0 in the meantime.

[maxbeatty]

Sorry to pile on but like others I discovered this during development, found my way here, and would appreciate publishing a new version with the fix. Thanks! 🍜

[alanshaw]

+1 please publish the fix

[XavierGeerinck]

+1, fix is needed, facebook auth doesn't work without it

[ldesplat]

Fixed by #101 and #107

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.