Comments (5)
Might be worth looking into any opinions expressed here around plugin dep resolution: outmoded/discuss#173
It may be better dealt with by plugin authors rather than plugin register
ers like glue.
from glue.
I looked at hodgepodge. Certainly it can help with broken plugins that one does not have control over. It could be interesting to merge this functionality into Glue so that one can still use registration options and plugin options. I'd be open to a pull request against the v3 branch.
from glue.
Cool. Perhaps I should update hodgepodge to hapi's ES6 style and get it tested on node 4 and 5. Should hodgepodge always be used during registration or should that be a glue option? Additionally, should the looseTally
hodgepodge option be exposed through glue options, or just keep it true
/false
?
Worth adding that the trick explained in the docs for a plugin author to force usage of hodgepodge during registration no longer works because unknown plugin attributes are now allowed. Probably for the best.
Last thing I'd like to add is that I don't wish to encourage plugin authors to lazily/unknowingly misconfigure their pluginsโ that's my only concern baking this into glue. At the same time, it would be nice for glue to have a more deterministic plugin registration order. Just wanted to throw it out there!
from glue.
The support for plugin ordering should be off by default and enabled as an option in the compose function options. Also, I'm not expecting to make Glue dependent on Hodgepodge, but rather add the ordering code to Glue itself.
I agree that providing this option is a hack. It is preferable that plugins are instead fixed to handle dependencies properly. I'm not interested in supporting this myself, but if the patch is minimal and functionality optional, I don't mind it existing.
v3 uses an array for registration/plugin loading, so plugins will be loaded in array order now. If that satisfies your need, then we can skip adding this.
from glue.
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.
from glue.
Related Issues (20)
- how do you pass in concurrent option to hapi? HOT 4
- Should we have a "ISSUE_TEMPLATE.md" for Glue? HOT 1
- How should I use routes in server config (failAction). HOT 3
- Add hook to transform plugin list before registration HOT 17
- Integration with webpack - dynamic import issue HOT 4
- Make hapi a peer dependency HOT 7
- Error: Cannot start server before plugins finished registration HOT 4
- Using glue with hapi-mongoose HOT 5
- server.events is undefined after glue compose HOT 5
- Server options load support? Migrating from hapi 16 -> 17 HOT 6
- Change module namespace HOT 1
- Change module namespace for v5 branch HOT 1
- Server cache options in hapi 18 cannot be passed HOT 3
- Action required: Greenkeeper could not be activated ๐จ HOT 1
- Update deps HOT 1
- Update joi HOT 1
- Add typescript type definitions HOT 2
- Only node 12
- No way of passing default route validator to glue HOT 1
- plugin.name is required
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glue.