GithubHelp home page GithubHelp logo

Comments (5)

devinivy avatar devinivy commented on September 26, 2024

Might be worth looking into any opinions expressed here around plugin dep resolution: outmoded/discuss#173

It may be better dealt with by plugin authors rather than plugin registerers like glue.

from glue.

csrl avatar csrl commented on September 26, 2024

I looked at hodgepodge. Certainly it can help with broken plugins that one does not have control over. It could be interesting to merge this functionality into Glue so that one can still use registration options and plugin options. I'd be open to a pull request against the v3 branch.

from glue.

devinivy avatar devinivy commented on September 26, 2024

Cool. Perhaps I should update hodgepodge to hapi's ES6 style and get it tested on node 4 and 5. Should hodgepodge always be used during registration or should that be a glue option? Additionally, should the looseTally hodgepodge option be exposed through glue options, or just keep it true/false?

Worth adding that the trick explained in the docs for a plugin author to force usage of hodgepodge during registration no longer works because unknown plugin attributes are now allowed. Probably for the best.

Last thing I'd like to add is that I don't wish to encourage plugin authors to lazily/unknowingly misconfigure their pluginsโ€“ that's my only concern baking this into glue. At the same time, it would be nice for glue to have a more deterministic plugin registration order. Just wanted to throw it out there!

from glue.

csrl avatar csrl commented on September 26, 2024

The support for plugin ordering should be off by default and enabled as an option in the compose function options. Also, I'm not expecting to make Glue dependent on Hodgepodge, but rather add the ordering code to Glue itself.

I agree that providing this option is a hack. It is preferable that plugins are instead fixed to handle dependencies properly. I'm not interested in supporting this myself, but if the patch is minimal and functionality optional, I don't mind it existing.

v3 uses an array for registration/plugin loading, so plugins will be loaded in array order now. If that satisfies your need, then we can skip adding this.

from glue.

lock avatar lock commented on September 26, 2024

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from glue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.