Breaking changes on 2.3.0 and 2.4.0 about glue

[lloydbenson]

Doesn't the || clause say that you CAN use the new one but the old one is still valid?

[rodfernandez]

Hi LLoyd! After a fresh npm install, I see hapi 11 there. Of course, no damage if the application has a shrikwrap.json targeting hapi < 10 , but you know... 😉

BTW, this will impact rejoice's versioning.

[lloydbenson]

of course but if you have hapi < 10 in your app, and have this glue version it should still install fine?

[lkptrzk]

i got bit by this as well. might not be the intended usage, but i wasn't including hapi in the package.json, only glue.

[lloydbenson]

I personally think we should have a major breaking change for hapi 10.x anyway so we can start using es6. But I am just trying to explain why the maintainer may not consider this a breaking change.

[lloydbenson]

You could fix that by including hapi in your package.json file right?

[rodfernandez]

Correct, but it feels like a workaround. I will never understand semver...

[lkptrzk]

perhaps, i just switched the dep to be explicitly 2.2.0 (instead of ^2.2.0 or whatever i had it), haven't had time to circle back on how that behaves (instead i'm just working on upgrading node + npm etc).

if i'm supposed to be explicitly including hapi in the package.json, then the problem is my incorrect understanding of how to use glue, and it'd be awesome to get some context on why that is. if you're supposed to be able to use glue without specifying hapi in the package.json, then i'd consider this a breaking change.

[lloydbenson]

fair point.

[lloydbenson]

hopefully the maintainer will address these questions.

[gergoerdosi]

@rodfernandez, @lkptrzk: I recommend using http://semver.npmjs.com/:

[lkptrzk]

i think a concrete example will help -

using this server.js file:

var Glue = require('glue');

var manifest = {
  server: {},
  connections: [ { port: 3000 } ]
};

Glue.compose(manifest, {}, function (err, server) {

  if (err) {
    throw err;
  }

  console.log(server.version);
});

and this package.json:

{
  "name": "glue-bug",
  "version": "1.0.0",
  "dependencies": {
    "glue": "2.2.0"
  }
}

if you npm install && node server.js, the output is 9.3.1.

with this package.json:

{
  "name": "glue-bug",
  "version": "1.0.0",
  "dependencies": {
    "glue": "2.3.0"
  }
}

the output from the same script is 10.5.0.

a minor bump in glue caused a major bump in hapi

[lkptrzk]

that specific example used npm 3.3.8 and node v0.10.40

[csrl]

Yes, if you haven't explicitly called out the version of Hapi you want to use, then glue will pull in the latest. To that effect, glue 2.2.0 which allowed Hapi 9 would also be a breaking change. Basically any time Hapi major version is bumped, would require a major version bump of Glue if we took that approach. I've always considered that one should explicitly require a Hapi version in their project.

The README should get updated with this expectation.

I'm open to alternate approaches and suggestions. But I'm not inclined to bump Glue's major version just to add support for the next major version of Hapi. I do expect to move to requiring Node 4+ and Hapi 11 (or whatever the version of the week is) in Glue 3.0 as part of issue 31.

[rodfernandez]

A warn in the documentation is a great solution!

[csrl]

Commit db5cf3a resolves this.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.