GithubHelp home page GithubHelp logo

Comments (5)

patrickkettner avatar patrickkettner commented on June 24, 2024

I feel like this sort of logic is something you would do with the result of the store, outside of confidence itself. My reasoning being that it is sort of unbounded in possibilities - truncating strings, array values, etc. I am going to pass on this being a feature now, but anyone else feel free to voice support for it below. If there is enough support I am willing to reconsider.

from confidence.

devinivy avatar devinivy commented on June 24, 2024

@augnin with #81 and #82 landing, which allows setting values from environment variables, I would like to re-propose this feature, which would allow setting values additionally from criteria.

from confidence.

Nargonath avatar Nargonath commented on June 24, 2024

I don't have such use case right now but this feature feels useful. Perhaps we could see to standardize the format with the recent changes @augnin proposed. If you want to use the env as value you'd do: $env.myEnv perhaps we could follow the same syntax for your params proposal @devinivy aka:

const store = new Confidence.Store({
    c: {
        $filter: 'size',
        big: '$params.maxSize',
        small: 1,
        $default: 50
    }
});

store.get('/c', { size: 'big', maxSize: 200 }); // Evaluates to 200

or flip it onto its head and use the object notation for @augnin proposal with the environment variable:
{ $env: 'NODE_ENV' }

from confidence.

augnin avatar augnin commented on June 24, 2024

It probably makes sense to use object notation for env, with an additional $coerce operator. something like

{
    "mysql": {
        "$filter": "$env.NODE_ENV",
        "development": {
            "host": "127.0.0.1",
            "port": 3306,
            "user": "user",
            "password": "password"
        },
        "$default": {
            "host": { "$env" : "MYSQL_HOST" },
            "port": {
                "$env": "MYSQL_PORT",
                "$coerce": "number"
            },
            "user": { "$env": "MYSQL_USER" },
            "password": { "$env": "MYSQL_PASSWORD" }
        }
    }
}

the only problem with this is "$env.NODE_ENV" in filter is inconsistent with the remaining syntax.

from confidence.

Nargonath avatar Nargonath commented on June 24, 2024

Can't we use the same syntax in $filter? Allow for string or object so we don't break backward compat.

I have no clue if that's a big deal or not, I'm not really familiar with confidence codebase.

from confidence.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.