Comments (5)
I feel like this sort of logic is something you would do with the result of the store, outside of confidence itself. My reasoning being that it is sort of unbounded in possibilities - truncating strings, array values, etc. I am going to pass on this being a feature now, but anyone else feel free to voice support for it below. If there is enough support I am willing to reconsider.
from confidence.
@augnin with #81 and #82 landing, which allows setting values from environment variables, I would like to re-propose this feature, which would allow setting values additionally from criteria.
from confidence.
I don't have such use case right now but this feature feels useful. Perhaps we could see to standardize the format with the recent changes @augnin proposed. If you want to use the env as value you'd do: $env.myEnv
perhaps we could follow the same syntax for your params proposal @devinivy aka:
const store = new Confidence.Store({
c: {
$filter: 'size',
big: '$params.maxSize',
small: 1,
$default: 50
}
});
store.get('/c', { size: 'big', maxSize: 200 }); // Evaluates to 200
or flip it onto its head and use the object notation for @augnin proposal with the environment variable:
{ $env: 'NODE_ENV' }
from confidence.
It probably makes sense to use object notation for env, with an additional $coerce operator. something like
{
"mysql": {
"$filter": "$env.NODE_ENV",
"development": {
"host": "127.0.0.1",
"port": 3306,
"user": "user",
"password": "password"
},
"$default": {
"host": { "$env" : "MYSQL_HOST" },
"port": {
"$env": "MYSQL_PORT",
"$coerce": "number"
},
"user": { "$env": "MYSQL_USER" },
"password": { "$env": "MYSQL_PASSWORD" }
}
}
}
the only problem with this is "$env.NODE_ENV" in filter is inconsistent with the remaining syntax.
from confidence.
Can't we use the same syntax in $filter
? Allow for string or object so we don't break backward compat.
I have no clue if that's a big deal or not, I'm not really familiar with confidence codebase.
from confidence.
Related Issues (20)
- Publish on npm as @hapipal scoped package
- Replace ALCE file format usage in CLI
- Reorganize documentation for org-wide consistency
- Move from yargs to bossy
- Should we remove $env? HOT 6
- Should we remove Confidence.id.generate() and Confidence.id.criteria()? HOT 8
- How to perform logical operations? HOT 6
- Interest in CLI documentation? HOT 2
- Using 0 as default for coerce number returns undefined HOT 4
- New maintainer? HOT 6
- Manifest TLS options never work HOT 1
- Either allow matching "$undefined" or any non-falsy criteria value HOT 1
- Add support for environment variables in filters and values
- Remove module from hapi.js organization HOT 5
- Update hapi core modules to namespaced versions.
- Update deps
- Null values when filtering array items HOT 1
- $coerce array HOT 2
- Drop support for node v10 and below HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from confidence.