Happo not updating GitHub check status on base branch about happo.io

[trotzig]

I've just deployed a fix for the race-condition to happo.io. I'll close this issue, but feel free to reopen if the issue doesn't go away.

[trotzig]

Thanks for the report! I’ll look into this after the weekend. Sounds like something isn’t triggered the right way.

Are you using CircleCi, Travis, or a different CI system? This might not matter, I’m just making sure I can debug this in the best possible way.

[matthieu-foucault]

Thanks for the quick response!
We use CircleCI. I am wondering if us using a different base branch than the default might have to do with this issue

[trotzig]

It shouldn't matter, but I'll make sure to check that.

[trotzig]

Sorry for not reporting any results back here. I haven't forgot about it, it's just that other more important things snuck in before I had a chance of addressing this. 🤷

I hope to look at this during the week though.

[matthieu-foucault]

No worries, let me know if I can help debug the issue

[trotzig]

Okay, I think I've confirmed this is a race condition. The happo-cypress lib posts to the create job API endpoint right after it has initialized an async-report. In your case, the first call is very fast and posts a "success" status to the commit on GitHub right away. The second call posts a pending "job started" status as well, overriding the initial success status.

While this could be fixed in the happo-cypress library, I'm going to handle things on the server as well (working on that now). I think other clients might make assumptions about order not being important anyway, so we might as well fix in one place.

[matthieu-foucault]

This is working fine now, thanks!

[trotzig]

Excellent, thanks for the report!