Comments (2)
@trotzig this would be incredible, as it would certainly cut down on some build time for us! Thank you for pointing this out.
from happo.io.
Hi @JonahMoses 👋
The tmpdir
option isn't used (IIRC) when using the storybook plugin. This isn't supported right now, but it wouldn't take much to add an option to the happo-plugin-storybook code to allow reusing the build. Right around here is where the static package is created. We could add a useExistingBuild
option to the plugin and skip the whole build phase if it's true.
The only tricky part here is that happo will occasionally run twice -- once for the base commit (the commit that the PR is based on) and once for the tip of the PR. The build in step 1 can't be used for the base commit, so we'll have to figure out how to only conditionally apply the useExistingBuild
flag. It might involve setting an environment variable or something right around here to signal that we're generating the "previous" report.
from happo.io.
Related Issues (20)
- Running happo with more than 1 test file. HOT 3
- Error: Error: The NODE_ENV environment variable is required but was not specified. HOT 2
- Failures when running Happo HOT 4
- Trouble using Limiting Targets HOT 9
- Failure when running happo on safari browser HOT 2
- Spurious diffs with radio buttons on Safari HOT 8
- Environment variables in CircleCI run HOT 2
- Failures running Happo - File Already Exists HOT 4
- Script for `happo-ci-circleci` broken on custom base branch HOT 1
- Spurious diffs with iOS-safari HOT 4
- Script `happo-ci-github-actions` fails in 6.6.0
- Images created by `next/image` are not rendered in screenshots HOT 9
- Does this work with Rollup.js? HOT 13
- babel-polyfill always imported
- [Feature request] Run Function After Comparison Request HOT 6
- Can you expand support for babel-loader to include v9 HOT 3
- Failure due to maxHeight not being applied HOT 5
- Allow customization of prerender DOM HOT 1
- Request to apply a lock if the test is going to exceed the number of available snapshots HOT 4
- @babel/preset-react and babel-plugin-dynamic-import-node HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from happo.io.