GithubHelp home page GithubHelp logo

Comments (2)

JonahMoses avatar JonahMoses commented on June 14, 2024 1

@trotzig this would be incredible, as it would certainly cut down on some build time for us! Thank you for pointing this out.

from happo.io.

trotzig avatar trotzig commented on June 14, 2024

Hi @JonahMoses 👋

The tmpdir option isn't used (IIRC) when using the storybook plugin. This isn't supported right now, but it wouldn't take much to add an option to the happo-plugin-storybook code to allow reusing the build. Right around here is where the static package is created. We could add a useExistingBuild option to the plugin and skip the whole build phase if it's true.

The only tricky part here is that happo will occasionally run twice -- once for the base commit (the commit that the PR is based on) and once for the tip of the PR. The build in step 1 can't be used for the base commit, so we'll have to figure out how to only conditionally apply the useExistingBuild flag. It might involve setting an environment variable or something right around here to signal that we're generating the "previous" report.

from happo.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.