GithubHelp home page GithubHelp logo

Comments (3)

happypepper avatar happypepper commented on August 17, 2024

Thank you for creating this issue. This is indeed a bug, but I believe it will not affect the quality of the solutions. Inside evaluator.lua, M:evaluate_fast at line 137, the impossible hands are masked. Then inside terminal_equity.lua line 102, the possible_mask is created appropriately.

Would be grateful though if someone could compare results with fixing this bug and without, just to confirm.

from deepholdem.

NikolaosBouas avatar NikolaosBouas commented on August 17, 2024

Ok! Would a solution similar to the one used in leduc implementation be wrong? Specifically , calling get last_round_call_matrix for every possible last round board and then calculating an average over the results.
Also, I am having trouble understanding what kind of information the texas_lookup matrix, which is used in your solution , contains. Could you maybe explain it?

from deepholdem.

happypepper avatar happypepper commented on August 17, 2024

It would work but wouldn't be fast enough practically so I batched it in my implementation. Theres probably an even faster way to do it.
The texas_lookup table is used for evaluating hand ranks. It's the same as the handranks.dat in this repo: https://github.com/christophschmalhofer/poker/tree/master/XPokerEval/XPokerEval.TwoPlusTwo

from deepholdem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.