GithubHelp home page GithubHelp logo

Comments (8)

haraldk avatar haraldk commented on May 25, 2024

Thanks for reporting! I'll have a look at it.

Can you please update the issue with Java version, platform and vendor?

Thanks,

Harald K

from twelvemonkeys.

rtimpe avatar rtimpe commented on May 25, 2024

I'm on Mac OS X 10.9.1

$ java -version
java version "1.7.0_25"
Java(TM) SE Runtime Environment (build 1.7.0_25-b15)
Java HotSpot(TM) 64-Bit Server VM (build 23.25-b01, mixed mode)

from twelvemonkeys.

haraldk avatar haraldk commented on May 25, 2024

Thanks.

I could reproduce the issue. Seems like there's something weird with the ICC profiles (as expected from the stack trace) in these images. The images both contain a "Corbis RGB" ICC profile, which seems to be either broken, outdated or just not a very well supported version of the ICC spec.

They can both easily be read if I ignore the ICC profile.

I just need to find a way to single out these profiles, and either fix the ICC profile at runtime (like we do for a few other ICC profile issues), or just ignore the ICC profile altogether as a worst case.

Without the ICC profile the colors looks a little off, compared to Preview, so I think they should be fixed.

Harald K

from twelvemonkeys.

haraldk avatar haraldk commented on May 25, 2024

I just committed a fix for this issue, please give it a try.

db259bf

Harald K

from twelvemonkeys.

rtimpe avatar rtimpe commented on May 25, 2024

That fixed it, thanks!

from twelvemonkeys.

haraldk avatar haraldk commented on May 25, 2024

Good. :-)

from twelvemonkeys.

lauerc avatar lauerc commented on May 25, 2024

The current release 3.3.2 doesn't seem to contain this patch and crashes with the same exception.

Is there a twelvemonkey release which applied this patch?

from twelvemonkeys.

haraldk avatar haraldk commented on May 25, 2024

@lauerc The current release may be old, but not that old.... The patch is in the 3.3.2 release. But as the exception isn't really a TwelveMonkeys bug, but rather a ICC profile or ColorManagment issue, we might have to work around it in more places.

Please create a new issue, include the library version, JRE version, the relevant stack trace, and attach an image that can reproduce the problem. If the problem can't be reproduced through a trivial ImageIO.read(...), you also want to include the source code needed to reproduce.

PS: If you have the time, please get the latest master from GitHub, build locally, and test with that version. There will be a 3.4 release really soon

Best regards,

--
Harald K

from twelvemonkeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.