Comments (1)
The fix for this would be to create a separate rule that's used just for property names (in object patterns) and modify name
so that it no longer accepts '_'s, but IMO it's not worth it -- the add'l complexity in the Ohm grammar outweighs the benefits of this change, especially as the name spaces_
already discourages programmers from messing with this rule.
Plus, if we ever do decide to disallow '_'s in rule names, inline rule declarations won't be a syntactic sugar anymore. (Well, to be honest, they already aren't, b/c they are handled specially when they show up inside a parameterized rule.)
Anyway, here's a change that makes this comment true: a65ac62
from ohm.
Related Issues (20)
- getLineAndColumn is missing from the TypeScript types HOT 2
- Fix typing tests on main HOT 1
- Cherry-pick 5643c1e onto main
- Crash when calling `toString` on a NodeWrapper
- Release: ohm-js v17
- chore: Eliminate circular dependency between ohm-js and @ohmjs/cli packages
- grammar name of test example does not track grammar name changes
- Ohm-JS fails to complain about (some) missing semantic actions
- Type definitions for parameterized rules are inconsistent with behavior HOT 1
- Semantic action '[...]' has the wrong arity: expected 3, got 0 HOT 5
- Semantic actions for comments defined under the space rule HOT 1
- Add ability to type operation parameters & return values HOT 11
- CLI: Line endings in generated files vary across systems and platforms HOT 1
- cli.js is reading incorrect package.json file for version HOT 2
- Typescript example causes error HOT 1
- space with applySyntactic causes failure
- `toAST` incorrectly makes some nodes intermediate nodes HOT 1
- Indentation-sensitive grammar forgets consumed dedents HOT 1
- Syntax error handling? HOT 2
- Indentation-sensitive parsing: dedent not working? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ohm.