GithubHelp home page GithubHelp logo

Comments (17)

hardikvasa avatar hardikvasa commented on May 14, 2024

@freekeys thanks for your feedback :-)

yes, as you might have read in #53 , this is a known issue with Linux OS but works fine on Windows and OS X. I will add this information in the documentation. I will also try implementing the algo using chromedriver instead of geckodriver. But for now this is a won't fix issue.

Closing this issue for now. Feel free to post back if you found a workaround/solution to the geckodriver issue on Linux!

from google-images-download.

freekeys avatar freekeys commented on May 14, 2024

Thanks @hardikvasa!

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

was working with a sample/dummy code using chromedriver (and chrome browser) to download all the images returned by google search and that seems to work on linux, mac and windows. Let me keep this issue open until i do some more tests and merge it in this repo... :-)

from google-images-download.

jaredjohansen avatar jaredjohansen commented on May 14, 2024

I agree with free keys that this tool is way slick. Thank you for it!

I'll add a +1 for this feature request. I get the same error (on Ubuntu 16.06) as freekeys. I'd love to be able to download 100+ images from Linux OS.

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

Thanks @jaredjohansen for the feedback.

@jaredjohansen @freekeys the script is now updated to use chromedriver (with chrome browser) instead of geckodriver (with firefox browser).

I have successfully tested this script on Windows, Mac, Linux CentOS and Ubuntu and works perfectly fine. I could download 750+ images per keyword (everything that google returns).

You can follow the one time installation guide of chromedriver and chrome browser in the troubleshooting section of the documentation. Do let me know if this works for you.

from google-images-download.

elleobrien avatar elleobrien commented on May 14, 2024

@hardikvasa I am trying this but still not working for me- I have chromedriver (v2.9, latest version) in the same directory where I am calling googleimagesdownload. I'm doing

googleimagesdownload --keywords "cute" --limit 200 --chromedriver "./chromedriver"

And then I get the error
Looks like we cannot locate the path the 'chromedriver'. Please use the '--chromedriver' argument to specify the path to the executable.

It get the same error if I call it at a different location-
googleimagesdownload --keywords "cute" --limit 200 --chromedriver "/usr/local/bin/chromedriver"

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

@andronovhopf what linux OS are you running this from?

this could be due to various reasons:

  • If the path is correct but the chromedriver file does not have execute permission
  • can you try with an absolute path /usr/local/bin/chromedriver in the query instead of a relative path? (should not matter but just for testing purposes)
  • you do not have chrome browser installed in your system. In that case please look into the troubleshooting guide of this repo for links to install google chrome stable version

Also the latest version of chromedriver is 2.37
https://sites.google.com/a/chromium.org/chromedriver/downloads

from google-images-download.

elleobrien avatar elleobrien commented on May 14, 2024

from google-images-download.

elleobrien avatar elleobrien commented on May 14, 2024

Yep it's in my directory and permissions look good

eobrien@picket:~$ ls -la
total 61016
drwxr-xr-x 61 eobrien eobrien     4096 Mar 31 13:39 .
drwxr-xr-x  4 root    root        4096 Jun 21  2017 ..
-rwxr-xr-x  1 eobrien root    19354520 Dec 16  2013 chromedriver

Tried the following
sudo googleimagesdownload --keywords "cute" --limit 200 --chromedriver "/home/eobrien/chromedriver"

and

googleimagesdownload --keywords "cute" --limit 200 --chromedriver "./chromedriver"

Failure :/

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

@andronovhopf thanks for the info. would you mind running the below command again to see if it updates to a stable version?

sudo apt-get update
sudo apt-get install google-chrome-stable

This error could only be thrown if either the chromedriver was not found or the chrome browser was not found. This does not look to me like the issue is with chromedriver.

Did you happen to download the latest version of chromedriver (2.37) ?

I would also give this a shot:
sudo pip install google-images-download --upgrade

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

@andronovhopf

I did spin up an EC2 instance: ubuntu-xenial-16.04-amd64-server-20180306 (ami-4e79ed36)

And then i followed the exact same steps as mentioned in the accepted answer here to download google-chrome-stable
https://askubuntu.com/a/510186

and then i used your query and it worked perfectly fine.

from google-images-download.

elleobrien avatar elleobrien commented on May 14, 2024

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

Sounds good! Closing this issue since this feature has been tested and it works on all major OS.

from google-images-download.

jaredjohansen avatar jaredjohansen commented on May 14, 2024

Just tested it on my machine. Works for me too! Thanks hardikvasa!

from google-images-download.

xxllp avatar xxllp commented on May 14, 2024

I have get fine at first .but get the same error today

from google-images-download.

xxllp avatar xxllp commented on May 14, 2024

Unfortunately all 250 could not be downloaded because some images were not downloadable. 100 is all we got for this search filter!

from google-images-download.

hardikvasa avatar hardikvasa commented on May 14, 2024

@xxllp this could be because the qury that you used, Google image search only returned 100 images. Could you search on Google images page directly to see if that's true?

from google-images-download.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.