Comments (5)
Hey, I think you might want the routerPrefix option.
from unlighthouse.
Well golly gee. I honestly didn't look too hard at the options file, since I was trying to make something templateable with as little custom files between CI's as possible.
I didn't see --router-prefix
listed under the cli flag options page, but I tested just now to see if I could call it, and that worked. I also tested using the options file, which obviously worked as well.
Thank you for your response. My specific use case is fixed by this flag. Closing.
from unlighthouse.
Great to hear, I'll try and make this easier to find in the documentation.
from unlighthouse.
I had a similar use case and would be interested in this. For now Im working around this by manually replacing instances of "/assets" with the proper url prefixes for pointing at different folders on s3/cloudfront.
find .unlighthouse -type f | while read file; do
sed -i 's|/assets|/<url-prefix-s3-folder>/assets|g' $file
done
from unlighthouse.
I tested something similar and discovered it solves the issue, but also creates potential headaches. The fix replaces pathing on content of captured html if it posses /assets or /reports anywhere.
For example, our source domain might have origin.com/assets/vidoes/movie1.mp4
. The reports that get generated, capture the html of the page. These are found in /reports/page-path/lighthouse.html
. This lighthouse result page, now has the original captured html modified with the s3-folder unintentionally. Same if we have a news site or something origin.com/reports/all-the-base-belongs-to-us
.
I can see a producer or product manager scanning the results and noticing the captured page has wrong pathing or text in the reports pages and start raising issues. Yes, I can modify the script to exclude certain files, but it just creates more debt to deal with later. Simplicity is favored.
from unlighthouse.
Related Issues (20)
- Using `unlighthouse-ci --output-path= <path>` removes the target directory. HOT 3
- Static reports 404 on sub-reports and thumbnails as `/reports` (leading slash) is hardcoded somewhere in `_ctx.report.artifactUrl` HOT 2
- Puppeteer getting `protocolTimeout` HOT 4
- is it normal to see "WARN Lighthouse failed to run performance audits for "/business", adding back to queue." HOT 3
- CI scan randomly failing with NodeJS error HOT 1
- Query string URL paths ignored
- Static Report has broken full size images on performance tab HOT 2
- Protocol error (Target.getTargetInfo): Protocol error (Target.getTargetInfo): 'Target.getTargetInfo' wasn't found HOT 5
- CI scans failing since v0.11.6
- add "last updated" date / time to static report HOT 1
- Catastrophic Score HOT 7
- "Lighthouse failed to run performance audits for "/", adding back to queue." , in order to find the cause of the problem HOT 4
- Add support for LHCI basic auth HOT 1
- Mismatch between test site url and x-default causes no pages to be scanned HOT 2
- IndexedDB support HOT 1
- Running unlighthouse in Jenkins Chromium error
- tsconfig/base.json file missing in v0.12.2 HOT 11
- CORS issue when viewing the results on Windows HOT 1
- Usage on a self-hosted server? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unlighthouse.