Comments (2)
dnephin
commented on August 16, 2024
1
Thank you for opening this issue! A PR to document safe usage of this method would be great!
I fixed a related data race in #232, but I don't think it addresses this problem. While working on that PR I noticed this problem you describe also exists with EventDelegate. If you access or modify the *Node passed to any of those methods you will also end up with a data race. If you wanted to, it might make sense to document the safe usage on that interface as well. But we can also do that in a separate PR.
As for a better solution, it would probably be better to return a non-pointer, but that would be a breaking change. So I think for now documenting it is best. We'll have to look at a better longer term solution for a v2.
from memberlist.
krajorama
commented on August 16, 2024
Hi, any feedback welcome on my PR to document the issue, thanks.
from memberlist.
Related Issues (20)
- StateLeft members are never reaped HOT 3
- Node pointer passed to NodeJoin channel event delegate has no meta HOT 1
- Failed ping error running inside container
- Too many pending push/pull requests
- DATA RACE in invokeAckHandler
- How to detect and react to TCP only failures
- release new version HOT 2
- Feature request: Update state of node in memberlist
- MacOS arm64 support
- Data race in memberlist.go
- Is there a way to retrieve the member list without joining?
- "No private IP address found" error throwed on MacOS
- Is there any interface can I know when the cluster states got converged. HOT 1
- Question/Help: Anything need to be taken into consideration when implement a customize Transport with grpc
- Is it feasible to reuse the gassip port for grpc service? HOT 1
- `Join` with context cancelation
- Checking the state of the Node in NotifyLeave
- Can nodes be identify each MEMBERLIST without using UDP connections?
- memberlist fails in large-scale clusters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memberlist.