GithubHelp home page GithubHelp logo

Comments (1)

lonegunmanb avatar lonegunmanb commented on July 20, 2024

I've built plugin from source and debug on localhost, now the plugin doesn't complain about not finding inline_policies, but missing remote_policies, and I've found problem.
In path_secrets.go line 159:

// These just need to be detached, but we're not going to delete them because they're
		// supposed to be longstanding.
		remotePolicies, err := getRemotePolicies(req.Secret.InternalData, "remote_policies")
		if err != nil {
			// This shouldn't be part of the multierror because if it returns empty remote policies,
			// then we won't go through the remotePolicies loop and we'll think we're successful
			// when we actually didn't delete the remotePolicies we need to.
			return nil, err
		}

Lease created has no remote_policies as we can see from read alicloud/role/policy-based. We can just skip detaching remote policies.
I've submitted a pull request: #50

from vault-plugin-secrets-alicloud.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.