Extend Dash to accept only predefined values about hashie

[caalberts]

Starting with values sounds like a good idea. I'm not sure how large is the need for a type validation compared to predefined values.

I think a PR for the above would be super valuable and solve 99% of the scenarios.

💯

[jch]

That sounds like a good custom subclass. Would you be interested in trying to implement it and submit a pull request?

[Spaceghost]

I'll take a peek into it.

[dblock]

Bump.

[dblock]

I think this can be a new feature for Dash

property :gender, values: [:male, :female, :meat_popsicle]

[caalberts]

Should this be implemented as a validation instead? It would serve the 2 examples above, but also open to other validations in the future.

property :gender, validate: { within: [:male, :female, :meat_popsicle] }
property :age, validate: { within: age_range }
property :hair_color, validate: { with: ->(colour) { hex_color? }  }

[dblock]

Feel like an overkill because validate serves no other purpose than wrap with vs. within vs. something else and creates unnecessary mental overhead. For the first two we can make it equally predictable with a single keyword, values:.

property :gender, values: [:male, :female, :meat_popsicle]
property :age, values: 1..150 # a Range

I think a PR for the above would be super valuable and solve 99% of the scenarios.

The other half of this problem is that you don't always want values, but types. So I'd want

property :possible, type: Boolean
property :offset, type: Integer

The third, color, gets is a bit tricky, I think I'd want something more OO, which lets me define higher level classes, and would borrow from Grape, which is battle tested on this type of checks, extensibility, etc. It could look like this:

class Color
  attr_reader :value

  def initialize(color)
    @value = color
  end

  def self.parse(value)
    fail 'Invalid color' unless hex_color?(value)
    new(value)
  end

  def hex_color?(value)
   # ...
  end
end

property :hair_color, type: Color

Thinking out loud we would really want the entire coercion, types, checks system that is implemented in Grape using dry-types. Maybe as a separate gem even.

Thoughts?