GithubHelp home page GithubHelp logo

Comments (3)

jkeiser avatar jkeiser commented on July 20, 2024

This appears to be because integers do not have metaclasses to attach methods to. The solution is probably to make deep_merge recurse when an object does not implement deep_merge, rather than attaching the method to the object.

from hashie.

danielsdeleo avatar danielsdeleo commented on July 20, 2024

I'll also point out that adding new methods to objects at runtime clears the method cache (on MRI; rbx and jruby have more fine-grained caches, but there's still some overhead) which causes a noticeable performance hit. If this library is intended to be used in a webservice or any other use case where performance is important, I'd advise against any implementation relying on include or extend.

from hashie.

dblock avatar dblock commented on July 20, 2024

Resolved via #132.

from hashie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.