GithubHelp home page GithubHelp logo

Comments (7)

yonis9 avatar yonis9 commented on August 21, 2024

Hi, which components do you want to transform into functional components with hooks?

from home.

hashirshoaeb avatar hashirshoaeb commented on August 21, 2024

Hi @yonis9
Thank you for taking interest. I'm thinking of migrating all the components to hooks. This will make the codebase look more clean. I'll appreciate your thoughts on it.

Best,
Hashir

from home.

yonis9 avatar yonis9 commented on August 21, 2024

I don't think it's mandatory but we can do it.
In addition, maybe I didn't fully understand, but I think you misusing the state in some components, for example in the AboutMe.jsx:

this.state = {
  heading: "About me",
  aboutDev: Configs.aboutDev,
  instaProfilePic: '',
  showInsta: Configs.showInstaProfilePic,
  resumeURL: Pdf
};

}`

I think you can get rid of the "heading" in the state since it never gets changed and affects the component, unless you want to reuse this component for other purposes with the same logic.

If you need any help I will be happy to take part.

from home.

hashirshoaeb avatar hashirshoaeb commented on August 21, 2024

Yes @yonis9. I did this on purpose. So that I did not have to go into the code the change the text. Simply i can change this from state.

from home.

yonis9 avatar yonis9 commented on August 21, 2024

OK no problem. So I will convert it to use hooks tomorrow, is it fine?

from home.

hashirshoaeb avatar hashirshoaeb commented on August 21, 2024

Yeah Sure.

from home.

hashirshoaeb avatar hashirshoaeb commented on August 21, 2024

The purpose is to increase the readability of code. By:

  • removing unnecessary things,
  • changing components to hooks
  • reengineering complex logic to simple.

And feel free to share your ideas.

from home.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.