GithubHelp home page GithubHelp logo

Comments (5)

basvandijk avatar basvandijk commented on June 12, 2024

The problem probably occurs in Data.Vector.Fusion.Bundle.Monadic or Data.Vector.Fusion.Stream.Monad which both define RULES for enumFromTo.

from vector.

dolio avatar dolio commented on June 12, 2024

Can you check your benchmarks with the latest vector source? I merged a patch that is supposed to have fixed some RULES.

However, I actually don't expect it to work for Word32. I've been looking at the core for a simple test, and the behavior is very strange. There's a rule for Word32 that isn't firing, but the analogous rule fires for many other cases. Int16, Word16, Word64, Int64 and Int32 all work fine, but the Word32 rule does not fire and I'm not sure why. The Word32 and Int32 rules are in the same CPP block, so I don't see what the difference is yet.

from vector.

dolio avatar dolio commented on June 12, 2024

Never mind, I figured out the problem. WORD_SIZE_IN_BITS was undefined due to a missing MachDeps.h include.

If you try the latest, you should be getting good performance on all types, I think. If you can confirm, I'll close the bug.

from vector.

nh2 avatar nh2 commented on June 12, 2024

If you try the latest

I would like to, but I cannot figure out how to install vector from git (0.11) and the benchmark at the same time:

The benchmark dependencies (criterion) have vector < 0.11 in various places. I tried Cabal's --allow-newer flag, but that seems to lift all upper bounds of all packages, which gives me another build error.

How can I lift only the upper bounds on vector?

from vector.

nh2 avatar nh2 commented on June 12, 2024

While my question above persists, I managed to test this by cheating, setting vector's version to 0.10.9.100.

Benchmark results:

So this is fixed.

from vector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.