Comments (8)
whats the performance delta one way vs the other?
does this happen if you use vector head? (the bundle rep sometimes fuses better i'm told )
from vector.
Here are some benchmark results:
https://gist.github.com/takano-akio/e3c4c3c56ecc72b60b3d
In summary, the bad version is about 4.9x slower than the good one, with both versions of vector.
from vector.
how does the code optimize with vector HEAD/master?
from vector.
@cartazio I'm not sure that I understand the question. Would you like to see the optimized core, or something else?
from vector.
@cartazio The "Stream" constructors optimize away in GHC 7.10.1-rc1 and GHC 7.11.20150120
from vector.
@glguy in which case, its not really a bug on the vector side, but variability in how ghc optimizes, right?
from vector.
i've tried running your example code "good" vs "bad" benchmark locally with the most recent release of vector 0.11 on ghc 8.0.1 on os x with O2 optimization, and the timings seem to be essentially the same (only a ~ 10% difference but the total range of the times all lies in 80-100 microseconds)
so pending a code example that reproduces it with recent vector and ghc, i'm closing this and marking it invalid for now
from vector.
(that said, I really do appreciate that you provided code for the purposes of this bug)
from vector.
Related Issues (20)
- High level documentation? HOT 1
- overlaps for Data.Vector.Mutable behaves oddly for empty vectors HOT 2
- Performance issues with `foldl'` and large tuples HOT 3
- Add a variant unfoldrExactN, returning the resulting generator HOT 3
- Vector tests take more than 4GB memory to build HOT 3
- `Data.Vector.Fusion.Bundle.Size.Size` fields are not strict HOT 1
- Why is `Data.Vector.Generic.New.New` not a newtype? HOT 2
- Question: Is there a reason why `Unbox a => Maybe (Unbox a)` doesn't exist? HOT 1
- Is `vector` susceptible to the same fusion problems as `text`? HOT 2
- Improve compilation time HOT 3
- Split generic tests into separate package HOT 5
- Tests fail when built against QuickCheck-2.14.3 HOT 2
- New version vector 0.14? HOT 11
- Support `primitive-0.9` HOT 1
- Semantics and implementation of move for SoA vectors
- API using Applicative (traverse et.al.)
- Add total counterparts to partial functions, such as `head`. HOT 25
- catMaybes HOT 2
- Add strict boxed vectors HOT 12
- Data.Vector.Generic.New.unstream (and others) can't be specialized HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vector.