`postOffer` method unexpected error on server. about haveno-ts

[abouolia]

All the test cases passed, and the postOffer works for me. Thanks @woodser for your help, i'm sorry to forget to close the issue.

[woodser]

Excellent. Great to hear.

[woodser]

Is the arbitrator accessible? This line corresponds to looking up the arbitrator (needs a better error message):

https://github.com/haveno-dex/haveno/blob/8a0612a245ad0c10145bd9399926aebda07dcd54/core/src/main/java/bisq/core/offer/CreateOfferService.java#L234

[abouolia]

@woodser Yes, my arbitrator is running and registered. and still getting that error. Could you please check that method and confirm to me if it was work?

Jun-07 23:15:55.241 [grpc-default-executor-4] ERROR org.bitcoinj.core.Context: Performing thread fixup: you are accessing bitcoinj via a thread that has not had any context set on it. 
Jun-07 23:15:55.242 [grpc-default-executor-4] ERROR org.bitcoinj.core.Context: This error has been corrected for, but doing this makes your app less robust. 
Jun-07 23:15:55.242 [grpc-default-executor-4] ERROR org.bitcoinj.core.Context: You should use Context.propagate() or a ContextPropagatingThreadFactory. 
Jun-07 23:15:55.242 [grpc-default-executor-4] ERROR org.bitcoinj.core.Context: Please refer to the user guide for more information about this. 
Jun-07 23:15:55.242 [grpc-default-executor-4] ERROR org.bitcoinj.core.Context: Thread name is grpc-default-executor-4. 
Jun-07 23:15:55.243 [grpc-default-executor-4] INFO  org.bitcoinj.wallet.Wallet: Completing send tx with 2 outputs totalling 0.00105 BTC and a fee of 0.00 BTC/vkB 
Jun-07 23:15:55.244 [grpc-default-executor-4] INFO  b.c.btc.TxFeeEstimationService: We cannot do the fee estimation because there are not enough funds in the wallet. This is expected if the user pays from an external wallet. In that case we use an estimated tx vsize of 175 vbytes. 
Jun-07 23:15:55.244 [grpc-default-executor-4] INFO  b.c.btc.TxFeeEstimationService: Fee estimation resulted in a tx vsize of 175 vbytes and a tx fee of 8750 Sat. 
Jun-07 23:15:55.247 [grpc-default-executor-4] ERROR b.d.grpc.GrpcOffersService:  java.lang.NullPointerException: null
	at bisq.core.offer.CreateOfferService.createAndGetOffer(CreateOfferService.java:234)
	at bisq.core.api.CoreOffersService.createAndPlaceOffer(CoreOffersService.java:239)
	at bisq.core.api.CoreApi.createAnPlaceOffer(CoreApi.java:447)
	at bisq.daemon.grpc.GrpcOffersService.createOffer(GrpcOffersService.java:151)
	at bisq.proto.grpc.OffersGrpc$MethodHandlers.invoke(OffersGrpc.java:569)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

java.lang.NullPointerException: null
	at bisq.core.offer.CreateOfferService.createAndGetOffer(CreateOfferService.java:234)
	at bisq.core.api.CoreOffersService.createAndPlaceOffer(CoreOffersService.java:239)
	at bisq.core.api.CoreApi.createAnPlaceOffer(CoreApi.java:447)
	at bisq.daemon.grpc.GrpcOffersService.createOffer(GrpcOffersService.java:151)
	at bisq.proto.grpc.OffersGrpc$MethodHandlers.invoke(OffersGrpc.java:569)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Jun 07, 2022 11:15:55 PM io.grpc.internal.SerializingExecutor run
SEVERE: Exception while executing runnable io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed@3d64d0ec
io.grpc.StatusRuntimeException: UNKNOWN: unexpected error on server
	at bisq.daemon.grpc.GrpcExceptionHandler.wrapException(GrpcExceptionHandler.java:99)
	at bisq.daemon.grpc.GrpcExceptionHandler.handleException(GrpcExceptionHandler.java:56)
	at bisq.daemon.grpc.GrpcOffersService.createOffer(GrpcOffersService.java:178)
	at bisq.proto.grpc.OffersGrpc$MethodHandlers.invoke(OffersGrpc.java:569)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Jun-07 23:16:54.552 [InputHandler-localhost:4444] WARN  b.n.p2p.network.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown. 

[woodser]

Yes everything is working for me locally.

The command to register the arbitrator did change. Now it's Account > ctrl + r. Maybe that's the issue?

[woodser]

haveno-ts-0.0.6 is released which should improve the stack trace.

It runs against current master.

[abouolia]

@woodser Please check my code.

1. Created crypto payment account and took the getId() and put it to the payment account.

const payment = {
      accountName: "asdasd",
      assetCode: "ETH",
      address: "0xdBdAb835Acd6fC84cF5F9aDD3c0B5a1E25fbd99f",
}

client.createCryptoPaymentAccount(
      payment.accountName,
      payment.assetCode,
      payment.address
    );   

The crypto account has been created well without any issue./

const offer = {
    direction: "buy", // buy or sell xmr
    amount: BigInt("1"), // amount of xmr to trade
    assetCode: "ETH", // counter asset to trade
    paymentAccountId: "d477c9d9-ea9b-4fd4-8019-4f0581a0a13d",
    buyerSecurityDeposit: 0.15,
}
client.postOffer(
      offer.direction,
      offer.amount,
      offer.assetCode,
      offer.paymentAccountId,
      offer.buyerSecurityDeposit,
      offer.price,
      offer.marketPriceMargin,
      offer.triggerPrice,
      offer.minAmount
);

Keep getting the same unexpected error.

[woodser]

Your code should be using the await keyword with createCryptoPaymentAccount() and postOffer().

Did you try registering the arbitrator in the legacy app by going to Account, ctrl + r, and clicking the buttons to register?

Are you running the latest master and haveno-ts-0.0.6? Did it improve the client-side stack trace?

Were you able to run the arbitrator, Alice, and Bob by following the instructions?

Were you able to run all tests to verify the full environment setup?

[abouolia]

@woodser Yeah, i know createCryptoPaymentAccount and postOffer is async function. i did that.

• Arbitrator daemon works and registered it as you mentioned by Account, command + r.
• My Alice, Bob and Seednode daemons even the funding-wallet daemon work without any problem or red error.
• Mined some stagenet XMR coins to alice and bob addresses.
• In terms of testing, Tried to run the test but not all test cases passed some test cases failed.

• Updated the haveno-ts in UI repo. and the error didn't change still the same error.

[woodser]

Can you include more logs on the test failures? That could give a clue.

Also, want to confirm haveno is updated to latest master. haveno-ts will depend on it.

[abouolia]

@woodser After I removed the haveno and haveno-ts and built it again, got that error.

https://www.loom.com/share/a84efa444b7c4cac8e17844038e49264

[woodser]

Ensure no instances of monero-wallet-rpc are running before starting the daemons.

If that's not the problem, try deleting and recreating the arbitrator.

[woodser]

What environment is this? Running tests per the instructions should have been a first step to verify everything works.