GithubHelp home page GithubHelp logo

Comments (10)

l0nelyc0w avatar l0nelyc0w commented on May 22, 2024 1

I can begin working on this issue.

from haveno.

github-actions avatar github-actions commented on May 22, 2024

There is a bounty on this issue, the amount is in the title. The bounty will be awarded to the first person(s) who resolves this issue. Read the full conditions in the 'bounties.md' file. If you are starting to work on this issue, please write a comment here, so that we can assign the issue to you and avoid duplicated work.

from haveno.

woodser avatar woodser commented on May 22, 2024

@l0nelyc0w Checking in. How's it going?

from haveno.

l0nelyc0w avatar l0nelyc0w commented on May 22, 2024

@woodser I managed to get getXmrTxs working with the tests after the problem I had with null values, I followed ProcessModel.java and it helped to get the reply back. I have a question regarding createXmrTx(destinations) though, destinations isn't the only parameter for createXmrTx() right? It should also have the desired amount and the rest of fields that are mandatory to create a tx (as transfer in Monero RPC doc). And relayXmrTx() should take as it's only parameter the tx_metadata created by createXmrTx() (as relayTx in Monero RPC doc).

I think I will have a PR ready within the next 7 days.

from haveno.

woodser avatar woodser commented on May 22, 2024

@l0nelyc0w The amounts are part of the destinations. The only other required field is the account index which is always 0 for Haveno's wallet, so it doesn't need to be provided.

Yes, relayTxXmr() should take the tx metadata as an argument (I fixed the documentation).

from haveno.

l0nelyc0w avatar l0nelyc0w commented on May 22, 2024

@woodser

The only other required field is the account index which is always 0 for Haveno's wallet, so it doesn't need to be provided.

OK account index was the actual field of interest thank you for clarifying.

from haveno.

erciccione avatar erciccione commented on May 22, 2024

PR: #199

from haveno.

erciccione avatar erciccione commented on May 22, 2024

Reward sent. @l0nelyc0w please confirm you received it :)

from haveno.

erciccione avatar erciccione commented on May 22, 2024

Closing this as resolved.

from haveno.

l0nelyc0w avatar l0nelyc0w commented on May 22, 2024

I confirm I got the reward @erciccione thank you :)

from haveno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.