Comments (5)
@hawkw yeah I'd like to work on this. And the Clear
impl for Option
looks like a great way to move forward with this.
from sharded-slab.
In the
Slab
s case we need the type to be anOption<T>
in order to callOption::take
.
Since we're not actually returning the take
n item in this code path, can't we just use the Clear
impl for Option
?
Lines 15 to 19 in ffa5c7a
This should have equivalent behavior to the current implementation. I think it should be fine to have one code path that's used by both guards. It's only
Slab::take
that requires special-casing.from sharded-slab.
@bIgBV Are you interested in working on this? I'd like this to be addressed before we publish a release with the object pool API. If you're busy, I'm happy to take care of it so we can move closer to a release.
from sharded-slab.
Okay, great. I think this is the last release blocker for the pool.
from sharded-slab.
Looks like this probably isn't going to be possible with the current state of things (see #33 (comment) and #33 (comment)) so I'm not going to block the release on it.
from sharded-slab.
Related Issues (20)
- APIs for mutable (exclusive) access HOT 1
- make index type `NonZeroUsize` HOT 4
- Consider making `PoolGuard: Send` HOT 1
- Some way to query size of pool
- panic in Config RefCount::decr HOT 5
- Getting owned handles via pool results in unbounded memory growth.
- Build error: use of unstable library feature 'renamed_spin_loop' HOT 4
- fall back gracefully when max thread IDs are reached HOT 2
- Can I set Config::RESERVED_BITS to 32?
- All uses of the word "slab" on docs.rs link to the loom repository instead
- Migrate from lazy_static to once_cell HOT 1
- Slab::unique_iter panics when the slab is empty HOT 1
- Why does TID require one extra bit? HOT 2
- #![no_std] support HOT 2
- Document semantics of Slab::unique_iter HOT 2
- Draining iterator HOT 1
- Serde support HOT 6
- sharded-slab v0.1.5 tests fail to compile on 32-bit x86 HOT 5
- Unbounded memory growth with RESERVED_BITS HOT 4
- Return key immediately on insert duplicate value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sharded-slab.