GithubHelp home page GithubHelp logo

Comments (4)

tribal-tec avatar tribal-tec commented on September 2, 2024

I think it's related to not having a regex impl for gcc <= 4.8: http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions

@rdumusc correct me if I'm wrong and if there's another reason for choosing boost.regex here.

from servus.

jeremybernstein avatar jeremybernstein commented on September 2, 2024

GCC <= 4.8 isn't C++11 feature-complete anyway. GCC 4.8.1 is the first version which is: https://gcc.gnu.org/projects/cxx-status.html . It might be (IMO) better to put the boost stuff behind the SERVUS_USE_CXX03 ifdef, defining that automatically if the GCC version < 4.8.1.

from servus.

rdumusc avatar rdumusc commented on September 2, 2024

correct, when I last checked std::regex support was lacking in most implementations of the standard, but we should use it if in fact possible.
Otherwise, I agree that boost::regex should be an optional dependency. It is only used for printing a compatibility warning for the URI parsing, which I am not sure is even required any longer.

from servus.

rdumusc avatar rdumusc commented on September 2, 2024

Yes, implementation of std::regex_match comes with gcc 4.9 only (http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions)
Added compiler guards to not include the warning when compiling without boost:
#61

from servus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.