GithubHelp home page GithubHelp logo

Comments (5)

HCLarsen avatar HCLarsen commented on May 30, 2024

I like the idea, but I feel that it's out of the scope of this gem. The point of this gem is to block common passwords. Blocking "pwned passwords," as per this API, would be great, but would best be implemented in a different, yet albeit very similar gem. Perhaps a gem that could be called devise-pwned_password, thus providing a self-explanatory name.

from devise-uncommon_password.

michaelbanfield avatar michaelbanfield commented on May 30, 2024

Makes sense, thanks.

from devise-uncommon_password.

HCLarsen avatar HCLarsen commented on May 30, 2024

No problem. If you want something like that, I'd be happy to build it as a separate gem, or if you want to do it yourself, I'd love to see it when it's done.

from devise-uncommon_password.

michaelbanfield avatar michaelbanfield commented on May 30, 2024

Sure,

I've put together a basic gem and tested it with my use case (ActiveAdmin).

https://github.com/michaelbanfield/devise-pwned_password

This is the first gem I've written so any feedback is welcome!

from devise-uncommon_password.

HCLarsen avatar HCLarsen commented on May 30, 2024

The documentation is very good. Thank you for the mention in your Readme.

from devise-uncommon_password.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.