Comments (13)
Changes to support config files are checked into jreadey-master. Posix, docker, and Kubernetes should all be supported.
If anyone can try out this branch before I merge into master, that would be appreciated.
from hsds.
Commit looks reasonable to me, I'll try to get some burn in time for this on DCOS.
from hsds.
@jreadey , I didn't expect that this would be exclusive. I.e., environment variables don't work at all as a configuration option now? I had thought that it would be either, or maybe both with a precedence of env variables.
from hsds.
Oh, I see now... The config.yml must exist in the config directory. It doesn't look like the paths align to find admin/config/config.yml in the docker build at the moment.
from hsds.
@s004pmg - there are 4 levels of config overrides (from lowest precedence to highest):
- value in config.yml
- value in override.yml
- environment variable
- command line switch
The problem with environment variables with Docker or Kubernetes is that they need to be explicitly passed in the docker-compose script or k8s yaml config. As the number of config keys increased, this got to be a bit tedious. So I've put most of the config option in config.yml and removed most of the ones in the yaml.
For kubernetes the config.yml is passed to the pods in a ConfigMap. I'm not exactly what the equivalent would be for DCOS.
Could you take a look at the changes in basenode.py? I made some changes in DCOS related code here, but don't have the ability to test it.
I'll check on the docker build now. This is for docker-compose.posix.yml?
from hsds.
I think that environment variables can be more common in DCOS, but either way works there.
I think I was too terse in my last message, here's the stack running a Docker container built off of master:
Traceback (most recent call last):
File "/usr/local/bin/hsds-datanode", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/site-packages/hsds/datanode.py", line 230, in main
log.info("datanode start")
File "/usr/local/lib/python3.8/site-packages/hsds/hsds_logger.py", line 29, in info
if config.get("log_level") not in ("ERROR", "WARNING", "WARN"):
File "/usr/local/lib/python3.8/site-packages/hsds/config.py", line 111, in get
_load_cfg()
File "/usr/local/lib/python3.8/site-packages/hsds/config.py", line 30, in _load_cfg
raise FileNotFoundError(msg)
FileNotFoundError: unable to find config file
So that's a new stack I got by swapping in a new build. My point is that if we're going to still allow folks to primarily configure via environment variables, then the docker build should produce a stock config of defaults at that location. We shouldn't force them to mount in a blank config if they prefer to configure via environment variables.
from hsds.
Ok - got it.
Try out with this change: 5b7a0f1. If /config/config.yml is not found, the server will pull from /etc/config/config.yml (part of the docker image)
from hsds.
That gets the nodes starting, but now on to a new problem, looks like the node["host"] isn't getting set, so the cluster flails and doesn't self-organize.
I.e., this code in the headnode healthcheck fires:
if node["host"] is None: fail_count += 1 log.warn("Node found with missing host information.") continue
from hsds.
When I dump the node JSON, I get this:
{'node_number': 0, 'node_type': 'dn', 'host': None, 'port': None, 'id': None}
It's been a while since I've been in there, but I don't remember that being a valid node definition.
from hsds.
We've been testing successfully using commit 532565f for a few days now, I have no further concerns.
from hsds.
Are you still getting the strange state with node JSON?
from hsds.
Well, yes, though it gets past it. I get these in the head node for a while at start up:
WARN> Node found with missing host information.
Then it seems to go away after several minutes and the cluster finally turns ready (probably after several nodes turn over and restart). It's probably still worth debugging more because it may be delaying cluster startup, however it does settle in now.
from hsds.
I'll close this issue now. If anyone has questions/bugs with the config file usage, feel free to re-open
from hsds.
Related Issues (20)
- Setting up local HSDS server: error on first runall.bat in Windows HOT 1
- Update setup.py to remove setuptools deprecation HOT 1
- Enable dataset shape extent to be reduced HOT 1
- Support object copy operations
- Allow hdf5:// prefix in domain names HOT 1
- Can't write to H5T_ARRAY datasets
- 'Verbose' parameters for dset reads returns inaccurate until scan HOT 1
- Cannot run ./build.sh file HOT 2
- GET_Domains not returning all domains on Azure HOT 1
- FileNotFoundError: can't find hsds-node executable HOT 2
- Use numcodecs VLenArray for encoding variable length dataset chunks
- Support HEAD requests for dataset selection
- Support fixed-length strings with UTF-8 character set HOT 7
- Support broadcasting
- Reset data to fill value when decreasing then increasing extent of dataset
- Save padding/offset of fields in compound types HOT 3
- point selections can fail after shape update
- Support FLETCHER32 filter
- Compound Type Subsetting HOT 4
- Support N-Bit and scale offset filters
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hsds.