Comments (2)
Hi Zach!
I think that the React Native way of branching the code per platform is already enough as it is, for example, that case could be easily covered with:
<Text style={Platform.select({ios: human.largeTitle, android: material.display2})}>
Hello Typography!
</Text>
I can see different projects having different needs here and I can't come up with a use case that is gonna be so common to be worth abstracting in the library, and not in the projects.
Also, this part of the FAQ is kind of related: https://github.com/hectahertz/react-native-typography#why-is-this-library-exporting-stylesheets-and-objects-instead-of-components
Thanks for your idea 👍🏻, it's always worth to give these things a second thought!
Feel free to reopen if you'd like to discuss this further 🙂
from react-native-typography.
Yeah the abstraction I was getting at is confusing I think. Agreed with you on this one!
from react-native-typography.
Related Issues (20)
- Line height issue (Android vs iOS) HOT 3
- Styled Components HOT 1
- Add react-native-web to the example app
- Ship babelified code to NPM for the web platform HOT 3
- Typescript Support HOT 7
- Add windows support HOT 1
- Material typography V2 HOT 6
- Does it support other fonts? HOT 1
- Ability to support San Fransisco Compact natively
- systemWeight black HOT 1
- iOSUIKit will cut the bottom of Text if contains Chinese characters
- Scaling font sizes for bigger screens HOT 3
- Split out react-native to support other css-in-js frameworks HOT 1
- Material styles doesn't match with the guidelines HOT 1
- Republish example with update to Expo
- Missing types for dense and tall
- Dark Mode support HOT 1
- Workaround for new material guidelines? HOT 1
- styled-components expect lineHeight to contain units HOT 2
- [README] The logo does not appear properly in the dark mode of Github.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-typography.