GithubHelp home page GithubHelp logo

Comments (30)

ansgarbecker avatar ansgarbecker commented on May 12, 2024 8

Tada, here we go: The newest HeidiSQL build has 39 selectable style themes. You can set it in Tools > Preferences > General, at the very bottom.

Though there are a few new issues with this now. So be warned! We are still in the nightly builds here.

  • all themes I tested lead to empty text in first level of main menu
  • all themes show just empty or broken items in the context menu of table designer, view editor, routine editor, etc.
  • some listings have a light grey background in one or two columns, which is quite unreadable if the theme's font color is white (only a problem in dark themes)
  • SQL editors always have a hardcoded white background
  • two text memo's on SQL help dialog need another kick in the butt to show themed colors
  • various colored text does not work well with dark themes, e.g. the data types (numbers=blue, text=green, etc.) => solution: providing a dark and a light color preset, in preferences now
  • heidisql.exe file has grown from ~5MB to 8MB. But who cares?
  • new theme colors are applied to SynMemo's after Heidi restart
  • graphical glitches right besides main menu, showing random parts of SQL log
  • size grip in the bottom right corner of resizable dialogs shows unthemed colors, and does not seem to work anymore for the mouse
  • minor: status bar panels with icons show unique background color, not a potential wanted color gradient
  • main toolbar shows broken buttons now that I moved it out of a TCoolBar -> solution: put it into a TControlBar
  • white background / non transparent icons on buttoned edit controls
  • unthemed file open/save dialogs, task dialogs and message dialogs
  • empty leading space on main menu items (left side has 21px space, right side has normal looking 7px)
  • crash when closing (cancel or ok) any grid editor per buttonclick (e.g. the default value editor on the table editor's, or the grid value SET editor)

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024 5

Here we go: HeidiSQL compiled with Rad Studio 10.2 and Carbon Style selected.

Glitches I can most probably fix easily:

  • white SQL editors
  • lightgrey column on listings

Issues which I have no idea about yet:

  • broken main menu items - nothing visible, but space reserved
  • white background / non transparent icons on buttoned edit controls

tokyo-carbon-data
tokyo-carbon-database
tokyo-carbon-export
tokyo-carbon-gridexport
tokyo-carbon-mainmenu
tokyo-carbon-query
tokyo-carbon-rightclickmenu
tokyo-carbon-sessions
tokyo-carbon-table

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024 2

See attached screeny from a quick color assignment. Ugly. I guess real theming needs some dedicated theming component.
grafik

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024 2

This is a high-dpi screeny of a sample program created in Rad Studio 10 (trial), with an applied "carbon" theme. That's one from many, I guess 30 or 40, supported by RS10. Looks nice, doesn't it?
rx10-sample-program

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024 1

The icons are large because my Windows was in 150% mode. That was another thing I wanted to test with the new Rad Studio.
I will try to load Heidi's sources into that trial version, compile and make a screenshot to see how many new issues I have then :)

from heidisql.

cookieguru avatar cookieguru commented on May 12, 2024 1

@anselal Works great for me; have you tried clearing your settings?

from heidisql.

cookieguru avatar cookieguru commented on May 12, 2024 1

@anselal No idea. I would clear the settings, copy them, change the theme, then diff those, and go from there.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

Theming is normally done in Windows design settings. And I guess just making background colors dark would make HeidiSQL really ugly. That also implies light font colors, different grey scales in borders and disabled buttons etc.

Did you try to set a dark theme in your Windows settings?

See this forum thread: https://www.heidisql.com/forum.php?t=23756

from heidisql.

oliveru avatar oliveru commented on May 12, 2024

Right - like the Jetbrains IDEs, e.g. PHPStorm and so on.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

PHPStorm is Java-based, while HeidiSQL uses the Windows API for painting dialogs and other controls.

What about changing colors in your Windows design settings?

from heidisql.

oliveru avatar oliveru commented on May 12, 2024

For me no problem, don't know about the thread creator, just wanted to give some input.

from heidisql.

draknyte1 avatar draknyte1 commented on May 12, 2024

What about changing colors in your Windows design settings?

Is never really a valid solution.
While I've never had an issue with the colour scheme in Heidi, a simple solution to implement that gives users freedom isn't too hard.

New UI screen in settings, Have maybe 10 boxes which contain the default colours for certain components, allow changing them. Then just have BG/Borders/etc get their colours from there. Simple reset to default button and you're done. While I am not familiar with Delphi, I'd assume that it lets you do styling of windows to some basic extent.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

Of course with Delphi you can style some basic things, while it was never designed to implement its own style including border colors and some other minor things. You can see that in the screenshot above.

from heidisql.

rentalhost avatar rentalhost commented on May 12, 2024

Seems very complex make it possible because the Windows API, and too that there are a lot of places that need attention to make it really a full dark theme (and not only changing the white backgrounds to dark). It need change colors scheme, borders, shadows, so on. I could understand the "night operators" but I think that we could use solutions like WindowBlinds to fix it.

from heidisql.

RAYs3T avatar RAYs3T commented on May 12, 2024

@ansgarbecker Looks for sure better then the white skin. But the icons seems to be a little bit too large? (Like the icon in the title-bar).

What about tables?

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

Some code hints for myself:

Adding styles is doable via .rc file:
Carbon VCLSTYLE "Redist\Styles\Vcl\Carbon.vsf"

Listing included styles via style manager:
TStyleManager.StyleNames

Apply style to application:
TStyleManager.TrySetStyle('Carbon');

from heidisql.

cookieguru avatar cookieguru commented on May 12, 2024

New Dark theme looks amazing! I think you alluded it to it with the other issues you noted, but is it possible to change the font colors and row background colors in lock step with the theme?

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

Not yet. But that should probably be the way to go? But that would mean I have to go through 39 themes and watch out for fitting foreground/background colors. That sounds quite unsexy.

from heidisql.

cookieguru avatar cookieguru commented on May 12, 2024

Is there an easier way to open the vsf files besides the RAD trial?

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

.vsf styles can be created and edited with the integrated BitmapStyleDesigner.exe. Not sure if that's available separately from Delphi or RAD Studio.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

Various foreground/background colors are now "locked" to the active theme, so we don't have a light background on dark themes any more.

Though the SQL editors are still hardcoded white. They have many different font colors which are quite incompatible to dark themes, so it's not optimal to just adapt the background to the active theme. But I'll start over doing exactly that. Selecting better fitting SQL font colors may be left up to the user then.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

This is how it looks like, with some issues fixed:

grafik

from heidisql.

chrysler5798 avatar chrysler5798 commented on May 12, 2024

Hi,

A little display issue related to this new theme feature I think, there is an empty space on the left of main menu buttons for the default theme (Windows) :
2018-10-29_09-16-56

EDIT : Another issue, buttons between "SQL help" and "Load a SQL file" are transparents when you select another theme than Windows (default one).
image
EDIT 2 : it actually takes this transparent apparence when a button is disabled, so maybe you wanted to make it look like that ?

HeidiSQL version : 9.5.0.5314
Language : french

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

A little display issue related to this new theme feature I think, there is an empty space on the left of main menu buttons for the default theme (Windows) :

Yes, I can confirm that, although sporadically only. I have no clue about the reason, and no clue how to fix that.

EDIT : Another issue, buttons between "SQL help" and "Load a SQL file" are transparents when you select another theme than Windows (default one).

Yes, these are disabled buttons. This is intentionally done by the underlying library. Ok, they could look more stylish, yes, but I have very few to no influence on that look.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

I think we are complete at this point with themes. At least for the obvious stuff. So I'll close this issue now.

If anyone finds more issues with theming, then please report that in a new issue. Thanks!

from heidisql.

anselal avatar anselal commented on May 12, 2024

Using version 9.5.0.5371 my left panel (database tables) still shows up with a white background
on all themes

from heidisql.

anselal avatar anselal commented on May 12, 2024

@cookieguru thanks, clearing the settings did the job !!!!!

from heidisql.

anselal avatar anselal commented on May 12, 2024

@cookieguru is there a specific like I can remove from my settings file to get the work done ? Don't wanna lose all of my settings

from heidisql.

anselal avatar anselal commented on May 12, 2024

I found that yo must set the TreeBackground option like:

Servers\Unnamed\TreeBackground<|||>3<|||>536870911

this is for the Carbon theme.

from heidisql.

ansgarbecker avatar ansgarbecker commented on May 12, 2024

It is the "Session background color", which you have probably set for your sessions. You can safely remove that TreeBackground value from your registry. Or - preferably - you just select another color, via File > Select session background color.

from heidisql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.