GithubHelp home page GithubHelp logo

Comments (2)

mdecea avatar mdecea commented on August 16, 2024 1

This looks great, I think it will make it much easier.

I would add two requests as someone who has gone through the process of starting to use femwell recently:

  1. Please, make variable names a bit more understandable.
    In particular, I find the standard syntax for finding the modes very confusing:
lams, basis, xs = compute_modes(
    basis0, epsilon, wavelength=wavelength, num_modes=nmodes, order=1
)

xs is in reality E fields, but with this names it looks like some kind of coordinates. lams are effective indices but with this name look like wavelength.
My suggestion, rename xs --> E_fields, lams --> complex_n or something similar.

  1. I think it would be extremely useful to have an initial doc explaining a bit the terminology for someone who is not super familiar with FEM methods. What is a basis, what is an element, what does it mean to "construct" a basis with certain selected elements...

As an extra, documenting the methods would also be nice :).

Happy to help!

from femwell.

HelgeGehring avatar HelgeGehring commented on August 16, 2024

Thanks for the feedback!

  1. I think this will be fixed already by the object oriented refactoring, right? compute modes would only return a list of modes (or an object which can be treated like a list, but has extra functions like sort). The names of the fields are listed above, I think then things should get very clear :)

  2. Makes sense! let's add something soon :)

from femwell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.