dvlopt.kstreams.stream/process-values throws java.lang.ClassCastException about kafka.clj

[helins]

Thanks ! Indeed, simple mistake. Fixed in version 1.0.0-beta2

[smessems]

Hi, there is an error in the params order inside process-values:
(process-values stream
processor
nil))
(^KStream
[^KStream stream **options processor**]

It seems that the processor should be the second param and the option as third param.
(Not sure if you get notification on comments on closed issues - I will open a new issue in few days)

[helins]

Right ! That is why I keep it in beta for the time being. It is already being used in production but there are probably a few tiny bugs like that.

Fixed in the latest commit. Do you see anything else before I release it on clojars ?

[smessems]

Looks good so far. I was able to convert my system to the new version. I did not verified performance impact though. But I do not forsee issues.

…

On Mon, Dec 3, 2018, 11:12 Adam Helinski ***@***.*** wrote: Right ! That is why I keep it in beta for the time being. It is already being used in production but there are probably a few tiny bugs like that. Fixed in the latest commit. Do you see anything else before I release it on clojars ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AnO4WRfCIwFmBXAq0od1y5Ks9ymf2oLdks5u1OrigaJpZM4YzVF1> .

[helins]

You were using Milena ? The previous iteration ? From now on, the API is considered stable unless something significantly changes in the underlying Java libs.

When it comes to performance, as always, there is some cost to "clojurifying" Java libraries. However, I expect some of the heavy load is JITted away.

[smessems]

Yes, I was using milena. Awesome!

…

On Mon, Dec 3, 2018, 12:17 Adam Helinski ***@***.*** wrote: You were using Milena ? The previous iteration ? From now on, the API is considered stable unless something significantly changes in the underlying Java libs. When it comes to performance, as always, there is some cost to "clojurifying" Java libraries. However, I expected some of the heavy load is JITted away. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AnO4WTcNMuTqyA7pmKwNGDtoACioD1uiks5u1Po0gaJpZM4YzVF1> .