upnpc-static.exe reported as trojan about zeronet

[shakna-israel]

PyUPnP might be a place to start, though it adds Twisted as a dependency. (Of course, Twisted itself should be able to cover this, but who wants to write from scratch?)

[sirMackk]

Hi, I can look into this. It seems related to #20 as well, so might as well kill two birds with one stone. Do you know if someone is working on this or is it safe to dive in?

[HelloZeroNet]

I think nobody is working on it, so its free to go :)
I want avoid add extra dependencies, so it would be really nice to make it work using only gevent+standard libs.

[sirMackk]

Sounds great, thanks for the pointer!

[sirMackk]

Hi! I think I got it. It uses gevent + the stdlib. I've tested it with two UPnP enabled routers I have access to and it worked both times. I'll be able to test it with a third one this weekend.

Before I do final cleanup and submit a PR, do you know someone who could test my branch against their router/s? I don't have a lot of experience with UPnP and I'm trying to cover anything I might have missed. My branch: https://github.com/sirMackk/ZeroNet/tree/upnp_punch .

[HelloZeroNet]

Wow looks nice, good work! I'm going to test it later today.

[HelloZeroNet]

Just tried it and its working here! :) On Monday i'm going to test it on other routers.

[sirMackk]

Oh man, that's great! I posted a message on ZeroNet to see if anyone else wants to volunteer to test this functionality out. Might make a ZeroNet site to coordinate this type of effort.

[HelloZeroNet]

it's working at my workplace too :) So I think we can include it in the next release if its ok for you too.

[sirMackk]

Great! Ive fixed some small platform related bugs as well. I'll submit a PR
as soon as I get back from work. Thanks!
On Feb 24, 2015 10:55 AM, "ZeroNet" [email protected] wrote:

it's working at my workplace too :) So I think we can include it in the
next release if its ok for you too.

—
Reply to this email directly or view it on GitHub
#5 (comment).

[HelloZeroNet]

Fixed in 34f6d1e