GithubHelp home page GithubHelp logo

Comments (7)

henrikruscon avatar henrikruscon commented on May 25, 2024 1

I love playing with a narrow contrast color palette with everything I design. I'm also doing it on a Retina display with 500 nits of brightness.

I'm sure it might look very different on older displays.

I think you make a solid argument and I'll look into options for improving the split divider today ✌️

from hyper-chesterish.

joggienl avatar joggienl commented on May 25, 2024 1

Well, to be honest, this "narrow contrast color palette" is what makes me want to use this scheme so much :-)

Thanks in advance, curious to see the results!

from hyper-chesterish.

henrikruscon avatar henrikruscon commented on May 25, 2024

Thanks for your suggestion.

I feel like this is more of a border issue considering it'll look odd if the border and divider don't match. So I just pushed a version with a lighter border.

Hope that works for you ✌️

from hyper-chesterish.

joggienl avatar joggienl commented on May 25, 2024

Do you mean this commit 0c3188e ?

That actually made the border even darker not lighter.

from hyper-chesterish.

henrikruscon avatar henrikruscon commented on May 25, 2024

@joggienl

Commit message is wrong, the color is indeed lighter, you can compare them here

Left is old color, right is new one ✌️

from hyper-chesterish.

joggienl avatar joggienl commented on May 25, 2024

I see indeed, I did not compare the actual colors itself ;-)

For me the border and thus divider color still doesn't stand out enough. I do notice it little better on my retina screen, but on my non-retina screen it still is almost invincible.

The border color goes for windows/tabs and the split divider (as far as I know). For the window and tab this goes fine, it's a subtle difference which makes it look pretty. The border in this instance is not something you need to interact with (no dragging or so with the border).

The divider on the other hand is actually actionable. Thats why I made it way more white in my PR proposal: you need to be able to interact with it. Which is hard if you can't see it.

So, in short, do you see possibilities to make it even more lighter?

Aside from that it might also be nice to extend the example images with an image with some split panes in :-)

🤞

from hyper-chesterish.

joggienl avatar joggienl commented on May 25, 2024

Hey hello!

Curious, have you had any time for this yet?
I was also thinking what might be good addition for this: make the active pane "jump" out (or give the inactive ones a different color...

Not sure if that will fit in the theme, but it could be a nice addition..

from hyper-chesterish.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.