GithubHelp home page GithubHelp logo

Comments (19)

ninok avatar ninok commented on August 22, 2024 1

Thanks for creating the issue. Can you please also attach the style that you used for the geojson?

from harp.gl.

nzjony avatar nzjony commented on August 22, 2024 1

Removing the wontfix label, it seems to be a genuine problem. Could be related to the issue reported internally: HARP-10866

from harp.gl.

nzjony avatar nzjony commented on August 22, 2024 1

This is still a valid issue. I managed to recreate it, so will reopen.

from harp.gl.

nzjony avatar nzjony commented on August 22, 2024 1

@harrycollin , basically we don't handle rendering MultiPolygon's correctly when styled using solid-line.

It seems it is an issue with the way we use geojson-vt to do the subdivision, we need to know if the edge added is part of the original data or whether it is synthentic.

@robertoraggi created the internal ticket and can perhaps give some more info than I can describe.

Edit: Roberto described it a bit more to me, basically, geojson-vt will add such synthentic edges so that each tile has closed polygons, however when rendering the polygons with lines, we don't want to render these lines, because they will introduce artifacts.

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024 1

@nzjony thanks for the insight. I look forward to hearing more on this :)

from harp.gl.

nzjony avatar nzjony commented on August 22, 2024 1

@harrycollin , no worries. All going well, we plan to start fixing it in 1-2 weeks.

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024

@ninok Updated the original

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024

@ninok Where you see 'this.fillColor.hex' & 'this.strokeColor.hex' it is just a random hex colour for the moment.

from harp.gl.

ninok avatar ninok commented on August 22, 2024

Still cannot reproduce on Chrome 81 Ubuntu 20.04.
@HHammerite Can you try to load your file in this example: https://www.harp.gl/docs/master/examples/#geojson-viewer.html

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024

Interesting. I can't reproduce it either on that example at my original zoom level. Here is a screenshot of me zoomed out at a similar distance.
image

But I do see it when zoomed in a bit more.
image

But when zoomed even further, the whole layer disappears.
image

I think I might record a video and post it here because the experience is so inconsistent.

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024

Here is a video I recorded https://www.youtube.com/watch?v=5E9MdB9JHjc

from harp.gl.

stale avatar stale commented on August 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from harp.gl.

stale avatar stale commented on August 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024

@nzjony Awesome! Are there any initial thoughts on what could be causing this?

from harp.gl.

stale avatar stale commented on August 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from harp.gl.

nzjony avatar nzjony commented on August 22, 2024

@harrycollin , sorry no update on our side.

from harp.gl.

harrycollin avatar harrycollin commented on August 22, 2024

No problem!

from harp.gl.

stale avatar stale commented on August 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from harp.gl.

stale avatar stale commented on August 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from harp.gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.