Comments (5)
.overFullScreen support is implemented in 0.3.0
from hero.
Could you point out how the community could help you with this issue? I love your framework but for context transitions it's sometimes necessary to show "where you come from", because it's better to understand the context. Isn't it sufficient to store a snapshot of the presenting view controller instead of a pointer to it?
from hero.
@fruitcoder Yes, we can start working on this now. For the past few week I have been trying to clean up the existing API and drop the zPosition modifier that was needed to make Hero transitions.
About your suggestion with keeping a snapshot of the presentingVC. The problem is that it doesn't work when the screen rotates on the presented VC. Ideally the presentingVC should also rotate and re-layout its subviews.
There are 2 problems to be solved:
-
Hero currently doesn't store any state information after the transition. This makes it far easy to debug and also make view controller transitions independent. You can transition from any VC to any other VC without knowing which VC presented what. Many of the navigation helpers like
hero_replaceViewController
&hero_unwindToViewController
depend on this. -
The snapshots that Hero takes have to stay after the transition. Theses snapshots are in a container view during the transition. Which VC should we insert these snapshot into? Who should keep track of them? Any still, when the screen rotates, these snapshots won't be updated.
I am also not very familiar with UIPresentationController. I have to spend some time on that and see if that is something we can use to maintain state information.
from hero.
Thank a lot for this amazing library!
This issue is still happening to me - I can still see black background when transition finished.
let vc = MyViewController(...)
vc.hero.isEnabled = true
vc.hero.modalAnimationType = .selectBy(presenting: .pull(direction: .left), dismissing: .pull(direction: .right))
vc.modalPresentationStyle = .overCurrentContext
vc.view.backgroundColor = .clear
present(vc2, animated: true, completion: nil)
When I set animated property to false present(vc2, animated: false, completion: nil)
the background is transperent, but then I do not see the transition
from hero.
Any news on this?
from hero.
Related Issues (20)
- Animation not working for UICollectionViewDiffableDataSource HOT 1
- Request: Make HeroTransition::complete(after: TimeInterval, finishing: Bool) public
- Version 1.6.2 doesn't work with SPM HOT 16
- <Hero/Hero-Swift.h> file not found when I use “ pod 'Hero' ”.
- Animation doesn't work when navigationController pushing screen HOT 4
- OverFullScreen problem HOT 3
- HeroModifiers will fail when a nested `when` modifier exist
- 在tabbar控制器嵌套的navigation控制器中push进子页面,tabbar的显示/隐藏没有任何动画 HOT 2
- hero push animation is unable to turn off
- How do I keep the tabbar is not hidden when push
- Doesn't the demo project work? HOT 2
- Spring Modifier on dismiss view controller Hero.
- hidesBottomBarWhenPushed bug
- Demo cant be run.
- need help, match hero animation across multiple preseting viewcontollers HOT 1
- Default source code, why is there a black area at the top? HOT 2
- Black screen when removing VC
- CI/CD github action needs update to newer env
- Privacy Manifest HOT 1
- Library not loaded HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hero.