GithubHelp home page GithubHelp logo

Comments (13)

lkzhao avatar lkzhao commented on July 24, 2024

Should be supported. But the implementation is not that robust. Can you try turning on maskToBounds and see if that works?

from hero.

lkzhao avatar lkzhao commented on July 24, 2024

I will reimplement cornerRadius support when I have time.

from hero.

lkzhao avatar lkzhao commented on July 24, 2024

Is cornerRadius still not working for you?

from hero.

jaroslavas avatar jaroslavas commented on July 24, 2024

At the moment it doesn't work. View becomes square, animates and then becomes round again.

from hero.

hussc avatar hussc commented on July 24, 2024

Yeah me too :D

from hero.

Namedix avatar Namedix commented on July 24, 2024

Do we have any solution?

from hero.

hussc avatar hussc commented on July 24, 2024

I've just got it..
on the view, make sure to check clipToBounds is equal to true.

from hero.

Namedix avatar Namedix commented on July 24, 2024

@hussc
Unfortunately, it does not work in my case, maybe it is because I adds a shadow to View :/

from hero.

kylebrowning avatar kylebrowning commented on July 24, 2024

Same.

from hero.

thomers avatar thomers commented on July 24, 2024

I'm having the same problem - I'm setting a CACornerMask on a plain UIView with a background color, within a custom UITableViewCell.

The rounded corners are only showing AFTER the hero transition, during the transition they are square.

Setting setMasksToBounds:YES on the UIView or the cell's contentView does not fix it.

from hero.

iAmNaz avatar iAmNaz commented on July 24, 2024

The same issue is happening with me where I am using CACornerMask on many views. Before transitioning only the bottom are rounded as I expect it to be but during transition all corners becomes rounded. I think the masks somehow goes away for a bit then back.

My work around for the mean time is to put my rounded view in another view as subview then set the superview color to default. This worked for me and let me know if it worked for you.

Just guessing, during transition perhaps Hero does something on the view that affects or ignores some properties such as our case.

from hero.

pcjbird avatar pcjbird commented on July 24, 2024

what about this? the same problem.

from hero.

pcjbird avatar pcjbird commented on July 24, 2024

https://github.com/HeroTransitions/Hero/pull/593/files/d76949135880e2dbc08f57a7ea987b297192c380

great!!!!!!!!!!

from hero.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.