Comments (13)
Should be supported. But the implementation is not that robust. Can you try turning on maskToBounds and see if that works?
from hero.
I will reimplement cornerRadius support when I have time.
from hero.
Is cornerRadius still not working for you?
from hero.
At the moment it doesn't work. View becomes square, animates and then becomes round again.
from hero.
Yeah me too :D
from hero.
Do we have any solution?
from hero.
I've just got it..
on the view, make sure to check clipToBounds is equal to true.
from hero.
@hussc
Unfortunately, it does not work in my case, maybe it is because I adds a shadow to View :/
from hero.
Same.
from hero.
I'm having the same problem - I'm setting a CACornerMask on a plain UIView with a background color, within a custom UITableViewCell.
The rounded corners are only showing AFTER the hero transition, during the transition they are square.
Setting setMasksToBounds:YES on the UIView or the cell's contentView does not fix it.
from hero.
The same issue is happening with me where I am using CACornerMask on many views. Before transitioning only the bottom are rounded as I expect it to be but during transition all corners becomes rounded. I think the masks somehow goes away for a bit then back.
My work around for the mean time is to put my rounded view in another view as subview then set the superview color to default. This worked for me and let me know if it worked for you.
Just guessing, during transition perhaps Hero does something on the view that affects or ignores some properties such as our case.
from hero.
what about this? the same problem.
from hero.
https://github.com/HeroTransitions/Hero/pull/593/files/d76949135880e2dbc08f57a7ea987b297192c380
great!!!!!!!!!!
from hero.
Related Issues (20)
- Animation not working for UICollectionViewDiffableDataSource HOT 1
- Request: Make HeroTransition::complete(after: TimeInterval, finishing: Bool) public
- Version 1.6.2 doesn't work with SPM HOT 16
- <Hero/Hero-Swift.h> file not found when I use “ pod 'Hero' ”.
- Animation doesn't work when navigationController pushing screen HOT 4
- OverFullScreen problem HOT 3
- HeroModifiers will fail when a nested `when` modifier exist
- 在tabbar控制器嵌套的navigation控制器中push进子页面,tabbar的显示/隐藏没有任何动画 HOT 2
- hero push animation is unable to turn off
- How do I keep the tabbar is not hidden when push
- Doesn't the demo project work? HOT 2
- Spring Modifier on dismiss view controller Hero.
- hidesBottomBarWhenPushed bug
- Demo cant be run.
- need help, match hero animation across multiple preseting viewcontollers HOT 1
- Default source code, why is there a black area at the top? HOT 2
- Black screen when removing VC
- CI/CD github action needs update to newer env
- Privacy Manifest HOT 1
- Library not loaded HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hero.