image animation about hero

[jackpaster]

it looks off

[JustinM1]

check #31, might have to do with the zPosition.

[jackpaster]

@JustinM1 it didn't help. could i please Skype with you to show you

[jackpaster]

@JustinM1 I'm using this with dynamic cells, and the animation is not working properly if i set it with dynamic cells. I tried using the basic hero animation from your project in mine, but how would i use hero with dynamic cells

[lkzhao]

@jackpaster Are you still having this problem. I got time today, I can take a look at your problem.

[lkzhao]

Close due to inactivity.

[jackpaster]

@lkzhao Yes I am could you please take a look at it

[jackpaster]

@lkzhao sorry I couldn't talk to you sooner, I was away

[lkzhao]

Can you post a screenshot or upload a example project? Others might be able to benefit if they experiences the same problem.

[jackpaster]

@lkzhao sure, I'm still away on vacation with my family, and I will have access to my computer tomorrow. Is it fine if I post the example project tomorrow.

[jackpaster]

@lkzhao Thank you so much, I've been struggling with this problem for a month now and I've had no solution

[lkzhao]

Yes, no rush.

…

On Sun, Feb 5, 2017 at 11:21 AM jackpaster ***@***.***> wrote: @lkzhao <https://github.com/lkzhao> sure, I'm still away on vacation with my family, and I will have access to my computer tomorrow. Is it fine if I post the example project tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADNEatkE6jjROhVYDxVoVbUQePiR0_z9ks5rZfbVgaJpZM4LkGWz> .

[jackpaster]

@lkzhao Thank you

[jackpaster]

@lkzhao I am so sorry, my flight was delayed and I only got back last night. I will send it to you by tonight. I hope I didn't scare you off from helping me. Thanks hope you understand

[lkzhao]

Yea np

[jackpaster]

@lkzhao How should i show it to you. Do you want me to email the project to you or what should I do.

[lkzhao]

Upload it to github and sent me the link would be the best way.

…

On Thu, Feb 9, 2017 at 12:28 AM jackpaster ***@***.***> wrote: @lkzhao <https://github.com/lkzhao> How should i show it to you. Do you want me to email the project to you or what should I do. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADNEajiyyHRgGrZknwFzDnL4C_xTecbzks5raqPjgaJpZM4LkGWz> .

[jackpaster]

Example.zip
Here is my zip file of the project. My Skype is jackpaster22. I would like to sit down with you and have a quick conversation. what I'm looking to do is have a the same animation as the basic view controller you have in your hero. I want to have the image expand the way it does in snapchat. And what I'm looking for is when you hold down on a cell for more than two seconds. The cell shrinks to 4/5 the size its at the way it does on snapchat. You can definitely do both with your project but the project is not working with me. Can you help me and Skype with me please.

[jackpaster]

@lkzhao the project is up. Would you like me to take a video about the cell animation of it shrinking and expansion to a detail view controller, to show exactly what I'm talking about.

[jackpaster]

What do you think about skyping and did you take a look at the project

…

On Thursday, February 9, 2017, Luke Zhao ***@***.***> wrote: Upload it to github and sent me the link would be the best way. On Thu, Feb 9, 2017 at 12:28 AM jackpaster ***@***.*** ***@***.***');>> wrote: > @lkzhao <https://github.com/lkzhao> How should i show it to you. Do you > want me to email the project to you or what should I do. > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#42 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ ADNEajiyyHRgGrZknwFzDnL4C_xTecbzks5raqPjgaJpZM4LkGWz> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARCMmZLVttjgQDPjviP-UGcNo4j9B5ZKks5razPTgaJpZM4LkGWz> .

[lkzhao]

Yes, I have. Unfortunately I couldn't skype with you. It is a bit inconvenient.

For the expanding transition, it looks weird because you have multiple views with the same heroID blue inside your table view controller. You should only have one. It should be set during tableView(_:didSelectRowAt:)

For you shrink animation, you have to do some custom UIView animation. There are plenty of tutorials available online, here is one: https://www.raywenderlich.com/2454/uiview-tutorial-for-ios-how-to-use-uiview-animation

I have also noticed some autolayout constraints issues in your TableViewCell2.xib. Ideally you shouldnt have fixed height constraint on cell's subviews. They should be determined by the cell's height.

[jackpaster]

could you fix it and show me what it would look like

[lkzhao]

ExampleTableViewController.swift

    // MARK: - Table view data source
    
    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
      let cell = tableView.dequeueReusableCell(withIdentifier: "TablesIdentifier", for: indexPath) as! TableViewCell2
      cell.Image2.heroID = "\(indexPath.item)"
      return cell
    }
    
    override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
        let controller = UIStoryboard(name: "Main", bundle: nil).instantiateViewController(withIdentifier: "yes23") as! ViewController2
        controller.view.heroID = "\(indexPath.item)"
        present(controller, animated: true, completion: nil)
    }