GithubHelp home page GithubHelp logo

Comments (4)

hesther avatar hesther commented on August 24, 2024 1

Hi @ljmartin , this is a great suggestion (and vectorizing is always a good option to speed up code). Feel free to submit a PR anytime! Thanks for contributing to this project!

from espsim.

hesther avatar hesther commented on August 24, 2024

Hi @ljmartin, what is the tentative time-scale for your PR? I am planning on some updates that might affect that part of the code, and wanted to wait for the PR first. So if you are currently unable to submit it, I might just go ahead and introduce the changes you supposed. Upside: You don't need to worry about it. Downside: GitHub will not give you credit - so I just wanted to check in with you and ask what you think about it.

from espsim.

ljmartin avatar ljmartin commented on August 24, 2024

Hi @hesther, thanks for the ping - yes Ill submit a PR tomorrow! I was thinking of adding a test first to make sure it does what I think it does, but Ill just test it manually before submitting.
Cheers

from espsim.

hesther avatar hesther commented on August 24, 2024

Thanks! Yeah, I can add a test later- actually there aren't any tests yet (the current dummy test only loads the package) for any code yet, this is also on my todo list.

from espsim.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.