Rotation not working when other view controllers are presented on top about agwindowview

[hfossli]

Can you be a little more specific? Maybe a quick drawing of hierarchy?

[hfossli]

(Just to avoid any confusion)

[AdrianFlorian]

Sure, I think it's a weird case I'm having here, here's a screencast:

https://www.screenmailer.com/v/iuK5qAiauZY

Let me know if it's not clear.

Thanks a lot!
Adrian

[hfossli]

This is the most awesome github-issue I've read so far. Very clear and easy to understand. Thanks for taking that extra effort!

Firstly, this is a use case I haven't tested. I assumed AGWindowView would overlay modals – so here we go into unchartered territory.

Debugging: Can you check if this bug also occurs if you don't use AGWindowView? It could theoretically be some trouble with UIViewController and its supportedInterfaceOrientations?

As a final note: I don't recommend using AGWindowView for displaying small detailsheets like that. I rather recommend to display your detailsheet using the standard API's of UIKit. A simple approach could be to write [self.navigationController.view addSubview:modal].

[AdrianFlorian]

Hehe, thanks, and thanks for the quick reply :-)

The reason why I’ve used AGWindowView is that I’ve had some troubles with the orientation when adding my view to the application’s window ([[UIApplication sharedApplication] delegate] window]). Adding the view to the navigation controller’s view doesn’t work, might be because I’m using a UISplitViewController.

I just tried adding the view to the main window and it looks like the orientation issue occurs there as well, so it might be a wrong approach from me to present it like that.

How would you present a custom built modal view controller like mine?

Cheers
Adrian

On Oct 26, 2014, at 8:54 PM, Håvard Fossli [email protected] wrote:

This is the most awesome github-issue I've read so far. Very clear and easy to understand. Thanks for taking that extra effort!

Firstly, this is a use case I haven't tested. I assumed AGWindowView would overlay modals – so here we go into unchartered territory.

Debugging: Can you check if this bug also occurs if you don't use AGWindowView? It could theoretically be some trouble with UIViewController and its supportedInterfaceOrientations?

As a final note: I don't recommend using AGWindowView for displaying small detailsheets like that. I rather recommend to display your detailsheet using the standard API's of UIKit. A simple approach could be to write [self.navigationController.view addSubview:modal].

—
Reply to this email directly or view it on GitHub #16 (comment).

[hfossli]

Can you just for the sake of debugging try to open the browser (the modal) without displaying the detailsheet?

I just tried adding the view to the main window and it looks like the orientation issue occurs there as well, so it might be a wrong approach from me to present it like that.

Yep, AGWindowView does not do any magic besides rotating the view correctly. So this should be no different from AGWindowView.

[AdrianFlorian]

You’re right, it happens even if the modal is not on screen, so it has nothing to do with it nor the AGWindowView.

Just for the reference: it looks like it’s a common problem in UISplitViewController, if there’s a modal view controller on top the split view controller will not receive the ui orientation changes callbacks anymore - quite weird.

I’m closing down this this issue (as it’s not really an issue) and I’ll further investigate how to fix it - let me know if you’re curious to find out what the solution was :-)

On Oct 26, 2014, at 9:18 PM, Håvard Fossli [email protected] wrote:

Can you just for the sake of debugging try to open the browser (the modal) without displaying the detailsheet?

I just tried adding the view to the main window and it looks like the orientation issue occurs there as well, so it might be a wrong approach from me to present it like that.

Yep, AGWindowView does not do any magic besides rotating the view correctly. So this should be no different from AGWindowView.

—
Reply to this email directly or view it on GitHub #16 (comment).

[hfossli]

Okay, as I suspected, feared and hoped. :-)

Well, if you open up a question on stackoverflow I'll be happy to add a bounty of 100 points to draw attention. Just send me a link if you open a question. 👍

[AdrianFlorian]

There’s lots of threads on the subject on StackOvervflow, but no concrete answer to fix it (or none seems to work)

Seems to do the trick if I change the presentation style from Full Screen to Page Sheet.

Thanks for the help, I wouldn’t have thought it was because of this :-)

Cheers

On Oct 26, 2014, at 11:00 PM, Håvard Fossli [email protected] wrote:

Okay, as I suspected, feared and hoped. :-)

Well, if you open up a question on stackoverflow I'll be happy to add a bounty of 100 points to draw attention. Just send me a link if you open a question.

—
Reply to this email directly or view it on GitHub #16 (comment).

[hfossli]

👍