[BUG] tasks before 8 AM are being counted towards the previous day about asynq

[ghosx]

Do you have reproducible code and screenshots?

[naisev]

I have same problem.

[hibiken]

@xmwilldo thanks for reporting an issue.

Did you specify your timezone via SchedulerOpts.Location?

If so, would you mind providing some code snippets to help me investigate further?

[xmwilldo]

@hibiken Yes, I tried but it didn't work.

loc, _ := time.LoadLocation("Asia/Shanghai")
	mgr, err := asynq.NewPeriodicTaskManager(
		asynq.PeriodicTaskManagerOpts{
			PeriodicTaskConfigProvider: &TrainPeriodicTaskProvider{
				ctx:    l.ctx,
				svcCtx: l.svcCtx,
			},
			RedisConnOpt: asynq.RedisClientOpt{
				Addr:     l.svcCtx.Config.Redis.Host,
				Password: l.svcCtx.Config.Redis.Pass,
				DB:       10,
			},
			SchedulerOpts: &asynq.SchedulerOpts{
				Location: loc,
			},
			SyncInterval: 10 * time.Second,
		},
	)
	if err != nil {
		log.Fatalf("could new PeriodicTaskManager: %v", err)
	}

[xmwilldo]

I have these scheduled tasks, each task executes at least ten sub-tasks, but the statistical results are as follows:

[hibiken]

It's probably related to this one? hibiken/asynqmon#295

UI shows everything in UTC so I think we need to open a FR to support different timezone in the UI.

[xmwilldo]

This doesn't seem to matter, because the ui just shows the data in redis, and the data recorded in redis itself is wrong

[xmwilldo]

like this

[hibiken]

I see.
We need to update these helpers to be timezone aware (currently always use UTC):

asynq/internal/base/base.go

Lines 169 to 172 in fde294b

	// ProcessedKey returns a redis key for processed count for the given day for the queue.
	func ProcessedKey(qname string, t time.Time) string {
	return fmt.Sprintf("%sprocessed:%s", QueueKeyPrefix(qname), t.UTC().Format("2006-01-02"))
	}

asynq/internal/base/base.go

Lines 174 to 177 in fde294b

	// FailedKey returns a redis key for failure count for the given day for the queue.
	func FailedKey(qname string, t time.Time) string {
	return fmt.Sprintf("%sfailed:%s", QueueKeyPrefix(qname), t.UTC().Format("2006-01-02"))
	}

This may be a good first issue for someone's who's looking to contribute.

[xmwilldo]

I would also like to participate, but this PR#683 already exists. Thanks!