GithubHelp home page GithubHelp logo

Comments (5)

djc avatar djc commented on June 11, 2024 1

Yes, breaking out of the loop for that scenario seems reasonable. Would you be able to send a PR for that?

from hickory-dns.

djc avatar djc commented on June 11, 2024

Why are closing all of the process sockets like that? What is the purpose of doing so?

from hickory-dns.

dlon avatar dlon commented on June 11, 2024

I've seen sockets being closed/shutdown randomly on a few machines, but I can't tell you why. It might be something that the OS is doing. Regardless, it probably makes no sense to continue to receive/send on them, right?

from hickory-dns.

bluejekyll avatar bluejekyll commented on June 11, 2024

Seems like we should be treating this error differently, but, if the server socket is closing, that would imply the server can no longer be used. It would need to reopen the Socket. What is closing the socket?

To be clear, the socket registered as part of "register_listener" should be live as long as the server itself and never be closed until the server is shutdown.

from hickory-dns.

dlon avatar dlon commented on June 11, 2024

Would it make sense to simply break in the case where ENOTCONN is returned here? (This probably needs to be handled for the non-UDP cases as well.)

I suspect that this issue might occur when the process is suspended under some circumstances. Can't tell you what they are since I haven't been able to reproduce this myself, so I'm just speculating.

Arguably, this case should be handled regardless, since any process (running as root) can call pid_shutdown_sockets to close the sockets. There's no way to gracefully handle this at the moment.

from hickory-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.