GithubHelp home page GithubHelp logo

Comments (4)

bluejekyll avatar bluejekyll commented on May 23, 2024

Thanks for submitting this. I'll try and apply the patch you submitted and put up a PR as soon as I can. This might not be for a few days though.

from hickory-dns.

rbmj avatar rbmj commented on May 23, 2024

That sounds fine - next time I'll be less lazy and get github to do a proper fork for me.

from hickory-dns.

bluejekyll avatar bluejekyll commented on May 23, 2024

See the commit I just pushed. That incorporates your fix (mostly verbatum, though I made it fail a little nicer).

I wrote a new test harness for the named bin, which I had been planning on doing for a while, this gave me a good reason to. Anyway, you can run these tests with cargo test or more specifically cargo test --test z_named_test to test just ipv4 listeners, and both ipv4 and ipv6. I found at least on my mac that an ipv6 only listener is still routable from ipv4 via the standard ipv4 address mapping to ipv6, not sure if that is true on other OS'

edit: travis still has a bad ipv6 config, so I had to ignore the ipv6 test, you can test that with cargo test --test z_named_test -- --ignored

from hickory-dns.

bluejekyll avatar bluejekyll commented on May 23, 2024

I believe that the patch I submitted fixes this. If not please reopen.

from hickory-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.