GithubHelp home page GithubHelp logo

Comments (7)

TorsteinHonsi avatar TorsteinHonsi commented on August 29, 2024 1

However, I wonder why this option is set to false in native Highcharts update() function

It's for backwards compatibility reasons. I think it should be true by default in the wrappers, where chart.update is abstracted.

from highcharts-react.

KacperMadej avatar KacperMadej commented on August 29, 2024

Hi @rahildar

Thank you for reporting about the problem.

The update should be done with oneToOne argument set to true - docs. Currently there's no control over this, so this should be added.

Internal note: ...probably in a similiar way as was done for Angular - highcharts/highcharts-angular@8e7b8bf

from highcharts-react.

Denyllon avatar Denyllon commented on August 29, 2024

Hi @rahildar ,

Now it is possible to se the oneToOne parameter directly as a props of your component:
oneToOne={true}.

Live example: https://codesandbox.io/s/3xv686167m

from highcharts-react.

TorsteinHonsi avatar TorsteinHonsi commented on August 29, 2024

@Denyllon
Wouldn't it make sense that oneToOne defaults to true? It was designed to handle updating of array configurations, and it is probably unnecessary to require this to be set. Would be better to leave it to true by default, with the option to set it to false.

from highcharts-react.

Denyllon avatar Denyllon commented on August 29, 2024

hi @TorsteinHonsi ,

It make sense to me, and that's why I set it in highcharts-vue by default equal to true. I will commit the changes soon.

However, I wonder why this option is set to false in native Highcharts update() function, as well as in highcharts-angular wrapper.

from highcharts-react.

lucasdu4rte avatar lucasdu4rte commented on August 29, 2024

Hi everyone, I relied on the highcharts-angular when I did the pull-request and is set to false the default, I also see that true would make more sense.

It is enough to analyze the degree of impact in projects dependent on the package.

from highcharts-react.

Denyllon avatar Denyllon commented on August 29, 2024

@KacperMadej

So, we should consider to change it in angular wrapper too.

from highcharts-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.