GithubHelp home page GithubHelp logo

Comments (10)

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024

Another strange thing going on here is that correctFloat is called sometimes but not always on pxPos

from highcharts.

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024

Our build system messes up some function names, but I'm sure you can understand what is happening. This is rendering axis ticks

from highcharts.

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024

Note that this given code preserves behavior of choosing a passed-in opacity as the label opacity over anything else except if the label is off-screen (currently, if the tick is off-screen it will make the label invisible even if the label should be visible)

So if you restructure things, think about what you're doing I guess

from highcharts.

hubertkozik avatar hubertkozik commented on September 25, 2024

Hi @magnusanderson-wk. I am not sure what is not working on your side. Can you prepare a simple demo with the reproduced issue in an online editor that I could work on? You can start here: https://jsfiddle.net/BlackLabel/nyvmjzou/

from highcharts.

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024

https://jsfiddle.net/magnusandersonwk/rqnz3j9u/12/

from highcharts.

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024

Compare to 11.1 which has its own issues: https://jsfiddle.net/magnusandersonwk/rqnz3j9u/13/

The code above addresses those I think, though (as it improves a bugfix between 11.1 and 11.4)

from highcharts.

hubertkozik avatar hubertkozik commented on September 25, 2024

All of the x-axis labels are visible in your demos:
image
Can you say and maybe create an image or gif of what is exactly wrong in the demo you have provided?

from highcharts.

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024
  1. Notice that in current highcharts, the y axis label Dec does not render: https://jsfiddle.net/magnusandersonwk/rqnz3j9u/12/
  2. Notice that in highcharts 11.1, that label did render: https://jsfiddle.net/magnusandersonwk/rqnz3j9u/13/
  3. Notice that in highcharts 11.1, below Dec there is an extra axis tick rendering which is a bug
  4. Notice that in current highcharts, that tick is not present because it was fixed
  5. Notice that with the provided code, both bugs are fixed: https://jsfiddle.net/magnusandersonwk/rqnz3j9u/19/

I will admit I made some error copying my fix into this github issue, as I ran into trouble setting up step 5 for you. So use the code in that jsfiddle

from highcharts.

hubertkozik avatar hubertkozik commented on September 25, 2024

@magnusanderson-wk the issue you are facing is related to min/max values, which you set on x-axis. You are using categories, and you set those values as decimals, the correct usage in this case is to use integer value, like here: https://jsfiddle.net/BlackLabel/jw1t8L3s/ and everything will work correctly. I don't see any bug here, it looks to me, like a misconfiguration.

from highcharts.

magnusanderson-wk avatar magnusanderson-wk commented on September 25, 2024

I don't see the point of this not being changed? While it might be the case that it is a strange use case, it makes more sense with an area chart which is the reason we implemented this behavior in the first case: https://jsfiddle.net/magnusandersonwk/rqnz3j9u/23/

We are currently stuck supporting this and will have to maintain this change ourselves if not merged upstream. That in itself is not a great reason to merge this, but if you just read the code, it does seem like the code doesn't work as intended because it is hiding an in-bounds label for a tickmark that is out of bounds, with the label in-bounds.

There is nothing in the documentation that suggests that min/max should be integers on x-axis. In fact, it sounds like it can be decimal because there is mention of rounding it down.

from highcharts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.