Bump dependency to latest highlight.js 10.7.2 about highlightjs-cypher

[gusbemacbe]

Done, @akollegger and @joshgoebel.

[joshgoebel]

@akollegger Could I get a link to a GitHub issue or a thread of this problem? Minor versions don't typically "break" themes - though sometimes highlighting does change slightly - which could require a theme to be updated. Otherwise I'm also not sure how bumping a dependency here would have any effect on your theme at all?

[joshgoebel]

  "highlightjs": "^9.10.0",

Ok, that is OLD... all bets are off... I take back what I said. :-) it's possible something may indeed need to change if this hasn't been updated since version 9.

[gusbemacbe]

I'll fix it this afternoon. Please forgive us for the inconvenience.

[joshgoebel]

Still quite curious how a theme was broken though, grammar itself looks pretty clean - so surprises.

[akollegger]

The break surfaced as an unsatisfied dependency. It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.

[joshgoebel]

It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.

Ah yes the correct package name is now highlight.js, the older name was deprecated a year or more ago.

[ggrossetie]

Thanks @gusbemacbe !
I think we should probably release version 2.0.0 since it's a major bump? What do you think?

[gusbemacbe]

Thanks @gusbemacbe !
I think we should probably release version 2.0.0 since it's a major bump? What do you think?

Do you mean to create a new release here?

[ggrossetie]

Do you mean to create a new release here?

Actually, it's a development dependency so I'm a bit confused...

The break surfaced as an unsatisfied dependency. It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.

@akollegger could you please post the complete error message?

[akollegger]

Apologies, you're right that the dependency was not the root cause for my theme. The theme initialization api changed, which incidentally failed on requiring highlightjs-cypher but had to do with asset loading and not a problem with highlightjs-cypher itself.

-ABK

[joshgoebel]

The theme initialization api changed,

I wasn't aware we have any sort of API for themes?

[AdamRaichu]

Outdated issue.