GithubHelp home page GithubHelp logo

Support sending voice messages about hikari HOT 2 OPEN

davfsa avatar davfsa commented on June 21, 2024
Support sending voice messages

from hikari.

Comments (2)

hypergonial avatar hypergonial commented on June 21, 2024

I'm pretty sure the waveform= kwarg should be added to attachments, unless I'm mistaken.

Also, based on this, should waveform= be added to all hikari resource base types? Or should a new basetype be created?

from hikari.

PythonTryHard avatar PythonTryHard commented on June 21, 2024

I vouch for creating a new base type, something like VoiceMessage. Adding waveform= to all hikari resource bases sounds...iffy. I can't describe why, but intuition says it's iffy.

For implementation, I found librosa that does the downsampling in Python rather than having to offload to ffmpeg. The only pain is that librosa only does sample rate, not bit depth, though I assume with some nparray shenanigan the bit depth should be easy enough. It's just a graphical representation, not some audio nerd stuffs.

Although, considering librosa's dependencies, if we were to go with it as a "battery included", I'd rather we put it as another extra like hikari[voicemsg]. How many times do you see a Discord bot library ship with number-crunching dependencies?

from hikari.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.