GithubHelp home page GithubHelp logo

Comments (17)

GBrachetta avatar GBrachetta commented on July 22, 2024 1

Just sent you an invite to it. Hopefully it works! :)

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024 1

Great, I'll try that right away! Do I need to change any file or just rebuild? I'll take a look, thank you for letting me know!

Just install new dependency and rebuild.

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024 1

@GBrachetta Yeah, that is a feature, something like 'Backlink Context', mentioned in this issue hikerpig/gatsby-project-kb#1.

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024 1

Ah okay, thank you! I was confused because it's unformatted and unclickable, and because if I am in a page it was clear that the backlink references it.

Thanks a lot for bringing it back to life! 😄

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024

Sorry for your inconvenience.
I ran the master code locally without noticing strange behaviors. Could it be that you didn't not run yarn install after updating the code? I did add a new dependency so this is needed.
If that's not the problem, could you provide a github repo so I can reproduce and fix the problem?

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

Thank you for getting back about this.

That's strange, I indeed ran yarn install, and I get the same problem running the dev build as well as the deployed version to Vercel.

I also lost the preview of links on hover.

Is there any information I could provide you with in order to see how to debug the issue?

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024

Oh I did notice the 'page reloading' you mentioned now. That is introduced by gatsby-theme-kb version v0.3.0 since I rewrite the parser a little. I will fix it soon and update it here.
Thank you for the feedback 👍

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

That's great to hear, thank you very much! I also lost linking in deeper nested files:

So I have: readme.md linking to javascript.md (that works) but javascript.md linking to its own subfile doesn't work.

If I can provide you with any extra information, please let me know.

Here's one of my Foams deployed for you to check how I lost functionality (it all worked up to the latest update):

https://my-second-brain.vercel.app/

You can also see that backlinks don't work anymore.

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024

Did you set the foam.edit.linkReferenceDefinitions to off? I noticed that with this turned of, current gatsby-theme-kb will have problems with nested files. Since [[javascript-es6+]] will not have the correct path without linkDefinition. (I should update my README since it's misleading.)
If it's not offensive, could you provide the git repo of your notes, so I can test if it's OK after my fix? (It's OK not to, though)

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

Yes, I turned it to off because it wasn't working when it was 'on'. We had a short talk on discord about it.
Turning it off made it all work fine until the last update.
And of course you can see my repo, haha!

It's currently set to "private", can you still visit the link?
If not, I will make it public for you:

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024

Yes, I turned it to off because it wasn't working when it was 'on'. We had a short talk on discord about it.
Turning it off made it all work fine until the last update.
And of course you can see my repo, haha!

It's currently set to "private", can you still visit the link?
If not, I will make it public for you:

https://github.com/GBrachetta/my-second-brain

I can't view a private repo. And I don't know if it is possible to be just public for me (may I need to be a collaborator?)

The nested notes should work with the option value withoutExtensions(this is my option) or withExtensions now. I will try to make it possible with it being off since it's the most intuitive way, but I'm not very familiar with developing Gatsby plugins so this might take sometime.

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024

@GBrachetta The bug is fixed in [email protected], you can try update it in your project.

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

Great, I'll try that right away! Do I need to change any file or just rebuild? I'll take a look, thank you for letting me know!

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

Fantastic, that sorted it, I believe! 😄
The only difference I still see is that backlinks include now the original nested link to the current file, but perhaps that's intentional?

Screenshot 2021-02-14 at 16 21 18

Thank you for such speedy response, amazing work!

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

Please don't hate me for contacting again, just a small thing and perhaps it's my fault, but links to files other than .md give me a 404 now.

- [Emmet](./cheat-sheets/emmet-cheatsheet.pdf)

from foam-template-gatsby-kb.

GBrachetta avatar GBrachetta commented on July 22, 2024

Forget what I said. I realised about the two extra dependencies and that while trying to fix it earlier I reverted to the previous version. It all seems to be working perfect now, thank you so much!

from foam-template-gatsby-kb.

hikerpig avatar hikerpig commented on July 22, 2024

Forget what I said. I realised about the two extra dependencies and that while trying to fix it earlier I reverted to the previous version. It all seems to be working perfect now, thank you so much!

Good to see you got it done. 😁 ( I was asleep last night when you post the question ).

from foam-template-gatsby-kb.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.