Leaked promise inside a dropped context causes panic! about quickjs_es_runtime

[SreeniIO]

Cargo.toml

[package]
name = "quickjs_runtime"
version = "0.1.0"
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
anyhow = "1.0.43"
futures = "0.3"
log = "0.4.11"
simple-logging = "2.0.2"
quickjs_runtime = "0.5.1"
hirofa_utils = "0.2.1"

[andrieshiemstra]

How do you prefer we deal with this? Just log and don't panic or prevent the context from dropping?

[SreeniIO]

How do you prefer we deal with this? Just log and don't panic or prevent the context from dropping?

I guess we should do similar to the thread dropping. Don't execute any code related to the context once the context is dropped.

Preventing the context from dropping?

Does it mean the runtime knows there are leaked promises during context drop? If so, throwing an error when trying to close a context with leaked promise would be even better.

[andrieshiemstra]

Well i'm currently working on the Runtime/Realm adapters in utils and i could rewrite it so Realm(context) has an Rc, when that RC is dropped the context will be dropped. A Promise/Function whatever adapter could have a clone of that Rc so the Realm(context) is actually only dropped when the last Promise is dropped.. allthough i fear this may cause a lot of unintended non-dropping Realms..

So i'm leaning toward just logging and not panicking...

[SreeniIO]

Agreed. In my case, it's the user code and we have no control over it. So there may be some promises that are left unresolved too.

[andrieshiemstra]

could you please check if 0.6.0 fixes this?

[SreeniIO]

Yes, it did. Thank you so much!