A tagging system for injecting collections of dependencies [Feature suggestion] about factory

[hmlongco]

Glad you're enjoying Factory. (And the documentation. ;) )

Something similar to this is kicking around over in Resolver, but I'm still not totally convinced of the general need for such a thing. Your associated type and sugar make things type safe, but also makes it a little clunky to setup.

I think I need to kick it around in my head for awhile and see what comes up.

Just noting that your code has a significant problem in that you're storing a factory in an object that belongs to a container. Factory's are designed to be short-lived entities for several reasons, but one of them is that they contain a hard reference to their container so they can resolve when needed.

In short there's a retain cycle there. You may need to consider something like the following with key paths...

    func autoRegister() {
         tag(\MyContainer.processor1, as: pipelineProcessor)
         tag(\MyContainer.processor2, as: pipelineProcessor)
    }

Thanks for the work, regardless.

[hmlongco]

Then again, there's this...

extension Container {
    static var processors: [KeyPath<Container, Factory<Processor>>] = [
        \.processor1,
        \.processor2,
    ]

    func processors() -> [Processor] {
        Container.processors.map { self[keyPath: $0]() }
    }

    var processor1: Factory<Processor> { self { Processor(name: "processor #1") } }
    var processor2: Factory<Processor> { self { Processor(name: "processor #2") } }
}

Anyone is also free to add their own extensions and append to the array as needed.

[DoubleREW]

Seems like a really clean and intuitive alternative to a tagging system, thanks.
Maybe you could add this snippet of code to the docs (if it's not already there), I know it's just pure and simple Swift code, but maybe it could point developers coming from other DI frameworks that offer a tagging system in the right direction. Thanks again.

[hmlongco]

https://hmlongco.github.io/Factory/documentation/factory/tags/

[DoubleREW]

Thanks for taking that into consideration.
I've updated the forked repository following your suggestion, the previous poc also leads to an unattended behavior if you tag the factory in its computed variable.

[hmlongco]

I have the code for later consideration should I decide to implement this as a feature in Factory, but for now I think I'll go with the documentation suggestion and see if that covers most of the bases for most of the people.

Thanks for the suggestions.