Comments (3)
Hi @roblav. Thanks for pointing this out.
It looks like mismatched expectations about what should happen when npm start
is run.
I think npm start
was initially only going to build and start the design system (which only needs the v4-SNAPSHOT assets) and not the component library too (which needs v3-SNAPSHOT assets) because it's been deprecated. To get the component library running you need to run npm run comp-lib
and serve the generated component-library
directory locally yourself.
I can see that the v3-SNAPSHOT
stylesheets being built (as a by product of tests
task being run), and the component library browsersync output makes things confusing though.
I can see 2 immediate solutions to this:
- not building the v3-SNAPSHOT and removing the component library browsersync output so that the design system is the only thing built and run with
npm start
- include building the component-library when running
npm start
.
There are pros and cons to both. I'm in favour of 1. as we should be moving on from the component library and faster builds are always better, but i can see people needing both the v3 and v4 styles when developing locally.
Do you have any objection or preference to either? Is there a need for having both v3 and v4 assets available when developing locally? Maybe there's a third option which would keep the build time fast and offer a less confusing developer experience?
from assets-frontend.
It might help if these messages:
Building assets-frontend v3 and v4.
If you only need v4 run: npm start
Were displayed at the end of the build output rather than / as well as the start as they scroll off the screen so fast it's likely that no one sees them
from assets-frontend.
Fair point. Thanks @gordonmcmullan.
Closing this as it was fixed by #907.
from assets-frontend.
Related Issues (20)
- Details element shows double arrows in MS Edge
- Services using AF do not resize text
- The build fails when run against the latest LTS version of node HOT 3
- Tabs component doesn't demonstrate deep linking to a tab
- Random classes getting added to html tag and causing layout issues - v2.245.0 HOT 5
- The 'disclosure widget' for the summary/details element is hidden in Firefox unless the css display value is set to list-item HOT 5
- Character countdown usability HOT 1
- `character-counter` component doesn't support GDS-style commas in long numbers eg 3,000 rather than 3000? HOT 1
- Broken build due to missing path for Nunjucks
- Pattern Library compiled CSS issue
- Link style button(button--link) focus background colour is green HOT 1
- Issue with Stageprompt not recognising JQuery
- Example markup for Secondary buttons shouldn't include the button class
- stageprompt version included in minified application js doesn't cater for newer Google analytics.js HOT 5
- Minified JavaScript contains unquoted identifiers which are reserved words in IE8
- Inconsistency for Radio Button Toggles HOT 1
- hard coded "+" is not always wanted
- Message pattern layout breaking...
- timeoutDialog timer does not evaluate time elapsed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from assets-frontend.