GithubHelp home page GithubHelp logo

Comments (3)

rpowis avatar rpowis commented on August 16, 2024

Hi @roblav. Thanks for pointing this out.

It looks like mismatched expectations about what should happen when npm start is run.

I think npm start was initially only going to build and start the design system (which only needs the v4-SNAPSHOT assets) and not the component library too (which needs v3-SNAPSHOT assets) because it's been deprecated. To get the component library running you need to run npm run comp-lib and serve the generated component-library directory locally yourself.

I can see that the v3-SNAPSHOT stylesheets being built (as a by product of tests task being run), and the component library browsersync output makes things confusing though.

I can see 2 immediate solutions to this:

  1. not building the v3-SNAPSHOT and removing the component library browsersync output so that the design system is the only thing built and run with npm start
  2. include building the component-library when running npm start.

There are pros and cons to both. I'm in favour of 1. as we should be moving on from the component library and faster builds are always better, but i can see people needing both the v3 and v4 styles when developing locally.

Do you have any objection or preference to either? Is there a need for having both v3 and v4 assets available when developing locally? Maybe there's a third option which would keep the build time fast and offer a less confusing developer experience?

from assets-frontend.

gordonmcmullan avatar gordonmcmullan commented on August 16, 2024

It might help if these messages:

Building assets-frontend v3 and v4.
If you only need v4 run: npm start

Were displayed at the end of the build output rather than / as well as the start as they scroll off the screen so fast it's likely that no one sees them

from assets-frontend.

rpowis avatar rpowis commented on August 16, 2024

Fair point. Thanks @gordonmcmullan.

Closing this as it was fixed by #907.

from assets-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.