I can't untap `homebrew/cask` and `homebrew/core` about brew

[MikeMcQuaid]

@benbor Apologies that I saw all except that they were still listed by brew tap.

@reitermarkus can you fix this regression, thanks.

[MikeMcQuaid]

... but it would be good if brew bundle dump didn't create those entries in the Brewfile

Opened Homebrew/homebrew-bundle#1317 to address this.

[MikeMcQuaid]

It's already uninstalled.

[benbor]

@MikeMcQuaid thanks for your answer.

Could you please specify how did you figure it out?

command > brew tap shows the following output

> brew tap
homebrew/bundle
homebrew/cask
homebrew/cask-fonts
homebrew/core 

And command brew bundle adds taps homebrew/cask and homebrew/core into Brewfile.
Even I remove this two taps from Brewfile manually, brew bundle cleanup couldn't manage to deal with it

> brew bundle cleanup
Would untap:
homebrew/cask
Run `brew bundle cleanup --force` to make these changes.

> brew bundle cleanup --force
Error: No available tap homebrew/cask.
Run brew tap --force homebrew/cask to tap homebrew/cask!

I'm sure it is still some bug with that two taps in my scenario.

[Bo98]

brew tap behaviour did indeed change in #16710. I agree it is perhaps unclear that brew tap shows things but brew untap says they never existed.

brew bundle cleanup looks like a regression since #16710 involved breaking public API changes so everything that used it probably needs checking.

[benbor]

@MikeMcQuaid No problem

Thank you so much for maintaining Homebrew! Your hard work makes my daily routine much easier

[reitermarkus]

Will take a look.

So I guess it's only the error message that is unclear? Basically, you cannot untap homebrew/cask because it's always available when using the API.

[Bo98]

It's well-documented that running brew tap on homebrew/core|cask will give you a local git clone so the concept of "tapped" has largely been around that concept of having a local git clone. Similarly you run brew untap to get rid of a local git clone and return to API-only state. So it's a bit confusing that the brew tap list doesn't reflect the same idea and that you can run brew tap again on something from that list to actually fully install it.

brew bundle also seems to also now not work in API-only mode properly after the changes and thinks it needs to do a brew tap/untap.

[reitermarkus]

So should we only show taps that have a local clone, or show something like

homebrew/core (using API)

?

[Bo98]

I'd say show taps with local clone. If you want API information, it maybe could be added with --verbose - I'm cautious adding it in regular output given brew tap is machine-parsable, as demonstrated by how $(brew tap) is used in our zsh completions and in many other places around the internet: https://github.com/search?q=%22%24%28brew+tap%29%22&type=code

[madAndroid]

It appears that brew bundle dump is still being affected by this issue - the created Brewfile includes:

tap "homebrew/cask"
tap "homebrew/core"

... which means when attempting to install using this created file, I get this error:

Error: No available tap homebrew/cask.
Run brew tap --force homebrew/cask to tap homebrew/cask!

[madAndroid]

I've worked around the issue for now using:

brew tap --force homebrew/core
brew tap --force homebrew/cask

... but it would be good if brew bundle dump didn't create those entries in the Brewfile