Comments (10)
PRs welcome -- if you're game to give it a try, we'd be happy to help you finish off even a half-working attempt.
Sure, will give it a try when I am free.
from brew.
But we should try fixing this for
brew edit
. PRs welcome -- if you're game to give it a try, we'd be happy to help you finish off even a half-working attempt.
Agreed. Please scope this logic entirely into dev-cmd/edit.rb
if so, thanks!
from brew.
Original issue analysis is incorrect as the sandbox and build.rb
doesn't apply here.
But there is overall environment filtering going on and setting HOMEBREW_TEMP
does work: HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements
. This perhaps should happen by default for brew edit
but currently doesn't.
from brew.
Original issue analysis is incorrect as the sandbox and
build.rb
doesn't apply here.
Thank you for pointing this out.
But there is overall environment filtering going on and setting HOMEBREW_TEMP does work: HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements. This perhaps should happen by default for brew edit but currently doesn't.
Is there any side effect if the user sets HOMEBREW_TEMP
to TMPDIR
globally? Or do I need to wait for changes from brew edit
?
from brew.
Is there any side effect if the user sets
HOMEBREW_TEMP
toTMPDIR
globally?
It could break some builds that get confused by the long paths that TMPDIR
typically point to.
If you don't build anything from source you'll probably be fine. If you do encounter build failures, you can always try to unset HOMEBREW_TEMP
.
from brew.
Thank you for your reply ;), then I will temporarily leave this issue open. Feel free to close it if your team thinks it should not be implemented for brew edit
.
from brew.
You could probably also set
TMPDIR=/private/tmp
as a likely safer alternative (though I don't think HOMEBREW_TEMP=$TMPDIR
is that unsafe either).
But we should try fixing this for brew edit
. PRs welcome -- if you're game to give it a try, we'd be happy to help you finish off even a half-working attempt.
from brew.
Hi, after a rough reading of the edit command code I have some doubts.
I don't quite understand why HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements
can work. How does setting HOMEBREW_TEMP
affect the access to the sock file in TMPDIR
by exec emacsclient
? Is it because TMPDIR
is reset to HOMEBREW_TEMP
during command execution (not found in the code) or is there another reason?
from brew.
Is it because
TMPDIR
is reset toHOMEBREW_TEMP
during command execution (not found in the code)
Yes, this is done by bin/brew
.
from brew.
Is it because
TMPDIR
is reset toHOMEBREW_TEMP
during command execution (not found in the code)Yes, this is done by
bin/brew
.
But bin/brew
is just filter TMPDIR
and I miss up the logic that sets TMPDIR
back to HOMEBREW_TEMP
in dev-cmd/edit.rb
or other places like
brew/Library/Homebrew/utils/gems.rb
Lines 99 to 101 in ff950e6
HOMEBREW_TEMP=$TMPDIR brew edit karabiner-elements
work.from brew.
Related Issues (20)
- Failed to install Homebrew Portable Ruby (and your system version is too old)! HOT 4
- Improve error/warning when `brew install` refuses to install a formula from a tap with the same name as an already installed keg HOT 7
- shellenv.sh: csh/tcsh: Broken code for setting envvar MANPATH HOT 1
- Make `autoremove` idempotent HOT 12
- Run xattr -r -d com.apple.quarantine App.app on casks on Apple Silicon MacOS HOT 20
- Homebrew's brew alias is broken after update this morning on Debian machines HOT 2
- Are all of the `undef`s we use really necessary? HOT 27
- HOMEBREW_PIP_INDEX_URL is misleading and does not work-as-intended with some mirrors
- “Error: comparison of PkgVersion with String failed” when running `brew upgrade` HOT 3
- brew upgrade or install fails with comparison of PkgVersion with String HOT 1
- Brew link step fail if installing multiple formulae with common symlink using a system with symlinked /home HOT 6
- golang not update to 1.23.0 HOT 2
- Happened ruby runtime error on macOS Sequoia HOT 2
- Homebrew no longer correctly reads `HOMEBREW_DOCKER_REGISTRY_BASIC_AUTH_TOKEN` from /etc/homebrew/brew.env
- environment file variables are not honored
- `brew install` call `gh attestation verify` Disrespect `XDG_CACHE_HOME` HOT 3
- Fix failing tests and write other tests as well HOT 1
- Suggest to change the way to read file in export_homebrew_env_file HOT 4
- Add a more customizable ENV file loading process HOT 2
- Download does not start immediately, a lot of network traffic (file is downloaded twice?) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brew.