GithubHelp home page GithubHelp logo

Comments (5)

MikeMcQuaid avatar MikeMcQuaid commented on September 25, 2024

Great idea, thanks @Bo98!

from brew.

reitermarkus avatar reitermarkus commented on September 25, 2024

Definitely makes sense to automate this.

What's the difference between updating content in a vendor-install.sh file vs. updating it in a separate file? Obviously a separate file is easier to implement, so I guess my actual question is where does the update come from? The homebrew-portable-ruby release workflow? A workflow in this repo? Dependabot?

from brew.

Bo98 avatar Bo98 commented on September 25, 2024

The homebrew-portable-ruby release workflow?

Probably this.

What's the difference between updating content in a vendor-install.sh file vs. updating it in a separate file?

Sed replacing ruby_SHA based on pattern matching of the previous line is a bit messy but not impossible. It gets even more complicated when the minimum macOS changes (i.e. we change el_capitan to sierra) as we need to then parse the previous tag information too.

With a separate file you don't need all that at all as you can just do

echo > x86_64-darwin <<<EOS
ruby_TAG=${TAG}
ruby_SHA=${SHA}
EOS

from brew.

github-actions avatar github-actions commented on September 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

from brew.

alebcay avatar alebcay commented on September 25, 2024

#17557 landed in https://github.com/Homebrew/brew/releases/tag/4.3.8.

from brew.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.